From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA8B9A04DD; Fri, 20 Nov 2020 12:38:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04668DED; Fri, 20 Nov 2020 12:38:17 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DBC153B5 for ; Fri, 20 Nov 2020 12:38:13 +0100 (CET) IronPort-SDR: jPrFkbLOXNJGM+MN+4NBemHZJzJXEvIqbrvXuQkq1ELshhMMkUMAHtIoCijSWGkQjS6dwovMuv l62O3xiTj14g== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="168886590" X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="168886590" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 03:38:13 -0800 IronPort-SDR: GC3AgFjLDZz60s1SssHXUuh8TXed3Pcnjo2Lh/eTrWonR9BDZJHb4KKCl/GJvavGp9D1Z6HZlU Nv6LGSZp3kng== X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="360410062" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.212.249]) ([10.213.212.249]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 03:38:12 -0800 To: Yongxin Liu , dev@dpdk.org, thomas@monjalon.net References: <20201118025854.13455-1-yongxin.liu@windriver.com> <20201120022233.25498-1-yongxin.liu@windriver.com> From: "Burakov, Anatoly" Message-ID: <49afdba3-0a02-f100-6f14-9e03b1bfee36@intel.com> Date: Fri, 20 Nov 2020 11:38:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201120022233.25498-1-yongxin.liu@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] usertools/devbind: fix binding for built-in kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Nov-20 2:22 AM, Yongxin Liu wrote: > A driver can be loaded as a dynamic module or a built-in module. > In commit 681a67288655 ("usertools: check if module is loaded > before binding"), script only checks modules in /sys/module/. > > However, for built-in kernel driver, it only shows up in /sys/module/, > if it has a version or at least one parameter. So add check for > modules in /lib/modules/$(uname -r)/modules.builtin. > > Thanks for Anatoly Burakov's advice. Also, no need to add this last line to the commit log :) -- Thanks, Anatoly