From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 87CD8AAE8 for ; Fri, 20 Apr 2018 16:41:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2018 07:41:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,301,1520924400"; d="scan'208";a="52335116" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.249.235.3]) ([10.249.235.3]) by orsmga002.jf.intel.com with ESMTP; 20 Apr 2018 07:41:53 -0700 To: "Burakov, Anatoly" , dev@dpdk.org References: <1524187312-129804-1-git-send-email-jianfeng.tan@intel.com> <1524187312-129804-2-git-send-email-jianfeng.tan@intel.com> <93e616c5-292a-98ee-041b-462c098e90d0@intel.com> Cc: thomas@monjalon.net From: "Tan, Jianfeng" Message-ID: <49f118dd-d369-99cf-eae5-b3f6271cbabb@intel.com> Date: Fri, 20 Apr 2018 22:41:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <93e616c5-292a-98ee-041b-462c098e90d0@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] ipc: clearn up code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 14:41:56 -0000 On 4/20/2018 3:55 PM, Burakov, Anatoly wrote: > On 20-Apr-18 2:21 AM, Jianfeng Tan wrote: >> Following below commit, we change some internal function and variable >> names: >> commit ce3a7312357b ("eal: rename IPC request as synchronous one") >> >> Also use calloc to supersede malloc + memset for code clean up. >> >> Signed-off-by: Jianfeng Tan >> --- > > In general, > > Acked-by: Anatoly Burakov > > However, i think it would be good to have it rebased/applied on top of > IPC coverity fixes, in particular because this patch uses strcpy > instead of instead of strlcpy. Will rebase on those fixes patches. And send the v2. Thanks, Jianfeng