From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC39EA04A2; Fri, 17 Dec 2021 13:59:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A7BF4013F; Fri, 17 Dec 2021 13:59:57 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 186E140040; Fri, 17 Dec 2021 13:59:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639745996; x=1671281996; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=qUGUox2QcoE3hC5KfElif/E7D8dftyR/DwCiOucZZ+g=; b=j3zVk1f6XKQbHcg7a9APw6KA1vrEjAwYvjiSz/FzKGMwsKxhFsCSq8e1 DEsDeJ/wjM3nQQON/dxtsfQe7Jfuv0rUrRmwim2Xr1iD2fnA9GB8OOawh 9ZudujVMlqKfDA2ZYajY+YOxykpPba7XfiXs1s4Jho4DlXb5Nx7cIAykJ AHDpgjRWtJ2D4wf3/6OauaDmJ/Ihu243jM11fADpL7eSvPx2rkLrVX2hT GqRCLBzwSSfDV0F984rUhB/ODVKT74jNsNYjP42D9BI63UsRtgwNpeEoY UScabpINg5x4lbe9mrxoH8hdxSF23Iixce5khoeiojiFYuq8uokgvUJS4 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10200"; a="239559031" X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="239559031" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2021 04:59:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="662838565" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 17 Dec 2021 04:59:54 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 17 Dec 2021 04:59:53 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 17 Dec 2021 04:59:53 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 17 Dec 2021 04:59:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aE8We1kyvpHXLwvxQ1ljYUlbtwLvsnPcubb15ciNpuANugYYNQBrtUG0A+a/gkpw5vJ0zFqV3cj/WSxcmlHX5AKZhBKhKrey2IPhIBfEtj2Z4vwQWlkZ+vOUxWutN+YEKzgUrkSz8JGI6IjDWJd0enWQl7yjIWD637j27VuhifY7OfiwX8fNWAUa6nI2jzDu+h4RieAr6F/g31ynk35tSnugjR0ZYUxlGnh3UaAdh/NePDmZ3tKHp6Xuwa69AaW/yAp7hYFQRH0zUAYay2RfgN/BUiHJTbLmHQ3CT0lI2yB6MODMx1/Dc7B671827v0n9VmjCza8LTx8nuvQE4080A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dthvUMI2f0bVvlOr1ori5U30M+aPLrKfrvTr6kYQh8=; b=OHWyi3a5OvwtZ58Y54rIqCjYfhuFIHl4L6iBoade1ld3F/6XsZarKeJflNzgSi23yYJXIFfVAoHrUolYTmvplCpTZsd929ZqqM04evlJNrUuuuSyg42t2vywIbYxOx6Yltfu5f/dL1x/omsTrUl57LyDsmrqU7q7B//fUb6lclRL2CF1RXTEH+jx6OCB3EfA6H7huiUSBDJUSr+cj+P1k/M66WRCWvtLZaJmF6KxL7z15KngKHR7zEwg9QmaFe4mdFmQDgraA9X1ZtFTBgSzfEQY8L8hHsatYBX9mHBx4WzM4dwPlrllbxAjf7yEfo9W4GIlhhMlbNs+fqW5lgxi9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5915.namprd11.prod.outlook.com (2603:10b6:510:13c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 12:59:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%6]) with mapi id 15.20.4801.015; Fri, 17 Dec 2021 12:59:52 +0000 Message-ID: <49fa76c7-30fe-3128-81ac-38779f557f33@intel.com> Date: Fri, 17 Dec 2021 12:59:46 +0000 Content-Language: en-US To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , "stable@dpdk.org" References: <20211129123252.19408-1-viacheslavo@nvidia.com> <47e72a82-6c86-526a-f6d9-4a1c1fa9a977@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] net/mlx5: fix metadata endianness in modify field action X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0087.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 946f1600-07f9-4f6f-7ad7-08d9c15d1d61 X-MS-TrafficTypeDiagnostic: PH7PR11MB5915:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:765; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2CGxGeUl5zAhwrZ/bR1tvz7cju0z9j5YmwS+37upPP0+sbM9AP2JZqlsc/HpNuZZ4aPQNEOWF4ggM0zKd+CLn+zEDwLQM1Qw1fmX5RZjcmTbSTrOlFN2TPlmsyObRermV3fuWQXC+JFN3HTORNmYIJyF1YiIWttMwZFVKfcp6sAwUc8G/E7W78QOTeFRy+8X8pNvEGEmr/iQWpBsoIJrn29MVkMlXJnUDVdlic3DLMiIX6HsIPugjP5UlmrbM3k1LX3icMa6GQUocSyGOgV1YMjSyPrJy8iQVQ8KqxiAUZ5fd4i3w6XwEfUqGFRrCm9zGwzb41ULoEcCO/D/lsnT+Lf76uwfSJ2wxJT7Rgf6vllmfoKxnJcINyzi1CPxDrSZE9Z3/d9dobUL3nl6tpsp5s7GZ/hcycstpuUPSHljHt+1gChacsCv6l4rXTIRSEuaj+LRCZPO1bfpPZxccxkxwxGi8G7p3L+AGgf9tYv4wOgEHoE6H+oXzS5FcOTG9bf+JAHS09W/26xJxxHdhFoBR+D9TmoLLz7OWaNWcwmSDae2HTLKnuCZkNWL/FgNR7nrVSIoiiqO2eLlGfx2y8CzED4IniUJWeT3C8O/OKPLtd8dJY5fFjk9ytJBDi87HNalvYw9V2Or77ZjF5oJAkQfC6I/LHBJW33aqmIpdGFqViNobQSIHM9eUwvr2lEQw31+NXrNUqaFofBsQ6dplGPNqg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(5660300002)(26005)(6506007)(508600001)(31696002)(6486002)(4326008)(82960400001)(83380400001)(54906003)(86362001)(110136005)(316002)(53546011)(8676002)(38100700002)(186003)(6512007)(36756003)(6666004)(8936002)(2906002)(31686004)(66476007)(44832011)(66946007)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGRia2VhVVBGWHhQdmphWFB4N01wYWppc2lheFduV3Z1UlE0SFNCUGhicDJR?= =?utf-8?B?Z3BhZTF1ME5sRmRpWmM2NDVSbUFSdlFyOE9SSmROcFJxRm9abXZQVzIzSEJv?= =?utf-8?B?OEFHUVhPeHF5d0xYVVFEQkpBNi9tQU5SSGFoQ0p5Z0hqVXd2MGR6YXU1UFpB?= =?utf-8?B?eDhwcVpiK3VoaGx1WGxSajVKS2JyNkdxWWlxL01BTklkSTk4WWRGZDNSR04z?= =?utf-8?B?bmdxYitScWNJaC9scjQvdWNCaFJ4UGdCNTZSZ0ZZa29vcnNscUUrQ1o1TzM0?= =?utf-8?B?R2kzSEYzODRrOFpoKzVYQU51d0k5b0RNWHVhUmdyd09Cd3FjS0xFUFFUWTgr?= =?utf-8?B?QU9OM3pocHRBeEozdnMwYk1TNnJqcnRPMUs4TnBMSzI4bEEwRSs2VkNoNVpO?= =?utf-8?B?RFJQUzFWUEY4aHA3SDQ3b09uNnpMVm1xeEFROW5nZ3BEa3FWRWFUMnB1ZWhY?= =?utf-8?B?THhxRE5FWFhhUERlOVdrS0VndUc1WlNrWkxMdC9QQU90MWNwTENvTGNYdk1L?= =?utf-8?B?N0FvRWhUZWlSaVBoVVp5Yk5LSjlSeWY5N1JQM0UvOWtuT0xoYmRuWEJOV3R6?= =?utf-8?B?NUI4c2tPbWFNK3h4b3RMT25oanFzY21sRlJmOHArRHppVGx5RmZTSVBxblBP?= =?utf-8?B?QWt6WHlmc3N4bkFPRndtTlhOU3B6akJmcWtwUktzOVVCNStNQ0VsbmJ4cnRB?= =?utf-8?B?LzRjU2gvVDBnSFBoNmczQUNCZVN2SkZrYmxoODVjaENlNmpXTG0zSkpkbDBs?= =?utf-8?B?Uk83Y0Yvb283WjZnaGVBQ3U3V1JlMGduNERzUi9mME5xL2N0ekFBck1XT3BY?= =?utf-8?B?a0VhUmcycW14ZG1NTjdYVjU1ZmRITlNjcUgwaEpwRjdaUi9Ea0lGTUpyQUd2?= =?utf-8?B?d0Jhb0x4L0swZXY0MGxpd01adkkyODQ3ekVicGZGMG13cUd4QWlKaktQOVVP?= =?utf-8?B?SUQ5ZE5VUUcwZUFCZTlQMnZkN0dHVE5Ddk13aGFMQ0pvRnQ5VWtWZ2ljRU8z?= =?utf-8?B?ZzljZDJyeVdRRURkUTJKVUc1RGRkaFJOTGFtNUIwM3kvNE5Sc1MxczZZaCtT?= =?utf-8?B?dy9UcWFXbFFYU0lJZllvd21QdE1Yc1liY1RJZ3NITVZnSEFaSElMYUlwd2FB?= =?utf-8?B?N0hHRG1tMndVYnlHZ1R2K2dvdzFhZ1VJUXlpNStmMmV1VElEbFNSSUY1THFt?= =?utf-8?B?TnJDZktNVy90NitvbUdhb2o0L05GRjI5c3A5dTVGTEVHaHlsQ1Rmem1qem5Y?= =?utf-8?B?cVg3Z1lXNUVPbGcya0c1MTlSMEgvRlFtSjhnUU0raDdzTWtrdm9yb0lkdmRj?= =?utf-8?B?UVplOXFTUGNWL09DbFNoOWw2OXcwMENPVXBDSmI2ME5VeS9kYkJ0aVZiNklt?= =?utf-8?B?YlpnVERnWEh2YU82RmdMUzY1M2tVQWpNMnNrb20rSUJrZUFXQiticEdZMStr?= =?utf-8?B?dnhGRXhLSW9KWllpTXpiVVpjQlBJQ25sZis1NDhRbUtOdnFIMUpMbEJCVnBa?= =?utf-8?B?N2JoUFYrUVhRdSticmVHb3d2cjJtcDZTR3prN0RUT3VHOWpWMHZML0k1eWJT?= =?utf-8?B?QXpUSUF3KytBNWI0OHdlaktFU2ZuWG5nVm9DM0NremtuZzR1aEFBNzBSOXF6?= =?utf-8?B?TFRXc0JDNElWNDVyZzFzWXg3MTVobWZ5OThJaUQva1ZhUnNwZmZYMmVmVDN2?= =?utf-8?B?aXRpM1JvTCtnVVVTbGdWTDk0R2FoNnZxTXBQZUpiZCtDeGlnQ0JrMVBuQkRW?= =?utf-8?B?M2FYcXhpSVFHR0o2QTFKRWtRY1lZVFdWMG1JL2w2SXlWUzR5WktYc1VYbFFX?= =?utf-8?B?M29xS0k0ZFZSOTZzTm1USWZhaEIwR1U2RmlNU09kNVdhcEo1Z1RkWU0vTnEy?= =?utf-8?B?a2FWbDlFajJHR29QUUFjMGhoNG9xN1htdXhwcisrMnFNZm1BKzlRNkp6Y1BU?= =?utf-8?B?Z3RZWGxnVElrbUJHdDJFQm53Vm9FRVVNeTZqQWJuazh0OG5KblRlRmtxVGVk?= =?utf-8?B?SFFNSEF1RlVxSHJTMlNKK3NUdzV4RXFvOWs0Y3kwUFpLVEJkYnRpTGVVYXgz?= =?utf-8?B?T0piUW40R1h1U0M5eXYydmJkUUx1cEZEL1IwK21yUUt5TlBaMUJ1OW9jQS8z?= =?utf-8?B?NFlHNEtyZmpaUVcyd3hZQXZTd1RwcXNIZGxGK3o2MlNuNFdTL1lLVnlXWXVK?= =?utf-8?Q?mcOzbHolx4BOCagy2B4s5tQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 946f1600-07f9-4f6f-7ad7-08d9c15d1d61 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 12:59:52.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OrBnW7TdJjW3DVAVTqhHO6Z6MS4BqUQR4RgMMLjycyZS0VO7jRQncEs5b2SUN3p6NsW75WhdqvKtCVExOFbohA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5915 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/16/2021 9:50 AM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, December 7, 2021 15:45 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; stable@dpdk.org >> Subject: Re: [PATCH] net/mlx5: fix metadata endianness in modify field action >> >> On 11/29/2021 12:32 PM, Viacheslav Ovsiienko wrote: >>> As modify field action immediate source parameter the metadata should >>> follow the CPU endianness (according to SET_META action structure >>> format), and mlx5 PMD wrongly handled the immediate parameter >> metadata >>> buffer as big-endian, resulting in wrong metadata set action with >>> incorrect endianness. >>> >>> Fixes: 40c8fb1fd3b3 ("net/mlx5: update modify field action") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Viacheslav Ovsiienko >>> --- >>> drivers/net/mlx5/mlx5_flow_dv.c | 23 +++++++++++------------ >>> 1 file changed, 11 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c >>> b/drivers/net/mlx5/mlx5_flow_dv.c index 4834c752d9..1c6cae8779 100644 >>> --- a/drivers/net/mlx5/mlx5_flow_dv.c >>> +++ b/drivers/net/mlx5/mlx5_flow_dv.c >>> @@ -1465,7 +1465,7 @@ static void >>> mlx5_flow_field_id_to_modify_info >>> (const struct rte_flow_action_modify_data *data, >>> struct field_modify_info *info, uint32_t *mask, >>> - uint32_t width, uint32_t *shift, struct rte_eth_dev *dev, >>> + uint32_t width, struct rte_eth_dev *dev, >> >> Hi Viacheslav, >> >> Is removing (unused) 'shift' variable related to the problem mentioned in the >> commit log? > Related indirectly to metadata, but not directly to the issue. > "shift" is unused leftover after changing immediate value format. > And this patch just provides collateral cleanup. Do you think we should > separate into dedicated cleanup patch? Or mention this cleanup in commit > message? > if not directly related I think better to split on its own patch, this makes it more clear to possible future references to the patches.