From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5895D1B54F; Thu, 7 Feb 2019 19:01:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2019 10:01:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,345,1544515200"; d="scan'208";a="113186993" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 07 Feb 2019 10:01:09 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 7 Feb 2019 10:01:08 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by FMSMSX114.amr.corp.intel.com ([169.254.6.247]) with mapi id 14.03.0415.000; Thu, 7 Feb 2019 10:01:07 -0800 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: "Poornima, PallantlaX" , dpdk-dev , "Pattan, Reshma" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] kni: fix sprintf with snprintf Thread-Index: AQHUvFflSqKmXDxbsESYkHFzO4JBjKXVFQEAgAAWnoA= Date: Thu, 7 Feb 2019 18:01:07 +0000 Message-ID: <4A9690F4-0E49-4CB4-B39C-710BA737CB2A@intel.com> References: <1549263758-32677-1-git-send-email-pallantlax.poornima@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.228.113] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] kni: fix sprintf with snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 18:01:12 -0000 > On Feb 7, 2019, at 10:40 AM, Ferruh Yigit wrote: >=20 > On 2/4/2019 7:02 AM, Pallantla Poornima wrote: >> sprintf function is not secure as it doesn't check the length of string. >> More secure function snprintf is used. >>=20 >> Fixes: 3fc5ca2f63 ("kni: initial import") >> Fixes: b9ee370557 ("kni: update kernel driver ethtool baseline") >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Pallantla Poornima >> --- >> kernel/linux/kni/ethtool/igb/igb_ethtool.c | 41 +++++++++++-------- >> kernel/linux/kni/ethtool/igb/igb_main.c | 12 ++++-- >> .../linux/kni/ethtool/ixgbe/ixgbe_ethtool.c | 30 ++++++++------ >=20 > Overall updates looks good, but I am not sure if we need to update the ke= rnel > drivers in KNI. At least *_ethtool.c ones shouldn't be called at all. >=20 > Any objection to skip these files from this patch? yes, would skip the kernel modules. Regards, Keith