DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dey, Souvik" <sodey@sonusnet.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Patil, PraveenKumar" <ppatil@sonusnet.com>
Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
Date: Wed, 15 Oct 2014 12:30:49 +0000	[thread overview]
Message-ID: <4B8F36DD0FB25E47B3DA6F493BF591B70DC59844@inba-mail02.sonusnet.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725821393AEE@IRSMSX105.ger.corp.intel.com>

Any plans to support this in future in DPDK fragmentation code ?

-----Original Message-----
From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] 
Sent: Wednesday, October 15, 2014 5:49 PM
To: Dey, Souvik; Thomas Monjalon
Cc: dev@dpdk.org; Patil, PraveenKumar
Subject: RE: [dpdk-dev] FW: BUG in IP FRAGMENTATION



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dey, Souvik
> Sent: Wednesday, October 15, 2014 12:53 PM
> To: Thomas Monjalon
> Cc: dev@dpdk.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> We have not directly tried to use the 1.7 code with fragmentation 
> apis, but we did run through the 1.7 code and did not find any much difference between 1.6 and 1.7 code.
> I had wrongly mentioned out-of-order in my previous mail. Actually 
> out-of-order is working fine but we are facing issues with overlapping and duplicate fragments.
>  In the 1.7 fragmentation code also in file ip_frag_internals.c , 
> function ip_frag_process we also see this comment
> 
> 	/*
> 	 * errorneous packet: either exceeed max allowed number of fragments,
> 	 * or duplicate first/last fragment encountered.
> 	 */
> 
> Which indirectly suggest that the handling of duplicate first/last 
> fragment is taken as error. Same with overlapping fragment we could not find any piece of code which will be doing it.

Yes, that's right.
If we encounter a duplicate and/or overlapping fragment we treat it  as an error.

> 
> --
> Regards,
> Souvik
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 15, 2014 4:54 PM
> To: Dey, Souvik
> Cc: dev@dpdk.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> ME TOO, I HAVE A BUG WITH CAPS LOCK ;)
> 
> 2014-10-15 11:06, Dey, Souvik:
> > In DPDK1.6 do we support overlapped fragments while doing reassembly.
> > Also why we don't consider the first or last fragment to be out-of-order.
> > Are this known limitations in DPDK or they are not working due to 
> > some bugs in the code ?
> 
> Please test the latest version and explain how you see the bug.
> 
> Thanks
> --
> Thomas

      reply	other threads:[~2014-10-15 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 11:06 Dey, Souvik
2014-10-15 11:23 ` Thomas Monjalon
2014-10-15 11:52   ` Dey, Souvik
2014-10-15 12:18     ` Ananyev, Konstantin
2014-10-15 12:30       ` Dey, Souvik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8F36DD0FB25E47B3DA6F493BF591B70DC59844@inba-mail02.sonusnet.com \
    --to=sodey@sonusnet.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=ppatil@sonusnet.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).