From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0AD6E2C58 for ; Mon, 12 Mar 2018 18:57:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 10:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,462,1515484800"; d="scan'208";a="36669954" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 12 Mar 2018 10:57:20 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 10:57:19 -0700 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 10:52:25 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.25]) by BGSMSX151.gar.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002; Mon, 12 Mar 2018 23:16:13 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [PATCH v1] app/pdump: add check for PCAP PMD Thread-Index: AQHTtIXAQVHIqqbLSEytkOiqqp3gTqPCw22AgAolm1A= Date: Mon, 12 Mar 2018 17:46:13 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19F6BB@BGSMSX101.gar.corp.intel.com> References: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2A642D@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2A642D@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTI5MmMzZTYtMjM2Zi00NzZmLTk5MWQtMGI1ZTdiODgyNmMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJoUlB1d1haZ1czODFDQkY1M3A3V2FhcjRzQjlTY3pGOU91dGRZRzFcL3lOWEpPR3l0V2FXek1UeDdTRjlYV0FXUCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 17:57:21 -0000 Hi Reshma, I tried your suggestion, but the build fails even using warning or not usin= g warning. The reason is DPDK build expects pdump to be build. I am looking at other alternatives, how to get this done. In last effort, w= e may need to disable PDUMP to be build default from '.config' file. Thanks Vipin Varghese > -----Original Message----- > From: Pattan, Reshma > Sent: Tuesday, March 6, 2018 5:42 PM > To: Varghese, Vipin ; dev@dpdk.org > Cc: Mcnamara, John > Subject: RE: [PATCH v1] app/pdump: add check for PCAP PMD >=20 > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) $(error "Please enable > > +CONFIG_RTE_LIBRTE_PMD_PCAP") endif > > + >=20 > How about combining If(($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) check with > below existing if check? > with this, dpdk-pdump will be compiled only when both the flags are enabl= ed. >=20 > > ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y) > > > > APP =3D dpdk-pdump > > -- > > 1.9.1