From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Daly, Lee" <lee.daly@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: update description for functions
Date: Fri, 18 May 2018 05:03:50 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1ECECE@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <cf5175b5-cfa4-6fd0-4eba-a4da35c36b78@intel.com>
Thanks you for the corrections, I had sent the diff from the wrong folder. Will be sending out V2 for the corrected one.
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, May 17, 2018 6:03 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Mcnamara,
> John <john.mcnamara@intel.com>; Daly, Lee <lee.daly@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: update description for functions
>
> On 5/17/2018 11:59 AM, Vipin Varghese wrote:
> > Change adds extra information on name parameter for API
> > rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> > lib/librte_ethdev/rte_ethdev.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.h
> > b/lib/librte_ethdev/rte_ethdev.h index f8815e9..7387686 100644
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > @@ -3657,7 +3657,10 @@ rte_eth_dev_l2_tunnel_offload_set(uint16_t
> > port_id,
> >
> > /**
> > * Get the port id from pci address or device name
> > -* Ex: 0000:2:00.0 or vdev name net_pcap0
> > +* Ex:
> > +* - PCIe, 0000:2:00.0
> > +* - SoC, fslgmac0
> > +* - vdev driver name, net_pcap0
>
> driver name is "net_pcap", device name is "net_pcap0".
> Original "vdev name" seems more accurate, is there a reason to change it to
> "driver name"?
>
> > *
> > * @param name
> > * pci address or name of the device
> > @@ -3672,6 +3675,10 @@ rte_eth_dev_get_port_by_name(const char
> *name,
> > uint16_t *port_id);
> >
> > /**
> > * Get the device name from port id
> > +* Ex:
>
> What do you think say "Ex device name:" here and remove "device name" from
> below:
> PCIe, 0000:02:00.0
> SoC, fslgmac0
> vdev, net_pcap0, net_null0, net_tun0 or net_tap0, ...
>
> > +* - PCIe Bus:Domian:Function, 0000:02:00.0
> > +* - SoC device name, fslgmac0
> > +* - VDEV driver name, net_pcap0, net_null0, net_tun0 or net_tap0
>
> Why VDEV capitalized?
>
> > *
> > * @param port_id
> > * Port identifier of the device.
> >
next prev parent reply other threads:[~2018-05-18 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 10:59 Vipin Varghese
2018-05-17 12:32 ` Ferruh Yigit
2018-05-18 5:03 ` Varghese, Vipin [this message]
2018-05-18 5:12 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-05-21 15:15 ` Ferruh Yigit
2018-05-21 15:16 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1ECECE@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=lee.daly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).