From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 930F856A1 for ; Fri, 18 May 2018 16:23:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2018 07:23:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,415,1520924400"; d="scan'208";a="51966807" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 18 May 2018 07:23:10 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 18 May 2018 07:23:11 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.242]) by BGSMSX102.gar.corp.intel.com ([169.254.2.150]) with mapi id 14.03.0319.002; Fri, 18 May 2018 19:53:08 +0530 From: "Varghese, Vipin" To: "De Lara Guarch, Pablo" , "Doherty, Declan" CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: extend feature flags description Thread-Index: AQHT7qr1mSG9OSahEUutyB6Cn8lanaQ1hGTw Date: Fri, 18 May 2018 14:23:07 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1ED2F8@BGSMSX101.gar.corp.intel.com> References: <20180518132007.5401-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180518132007.5401-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzZmYWY1YzMtY2JlZC00NmJkLWE4MWEtY2JkYTQ1Mzc5OWJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJldEUzekEybDQzcHJDd2JoVm85dVBjM1VoUjI2U284VGtBNE94RWRPR2kraWoxMVRlR3B0YVp3VFwvMzgzc2IzeiJ9 dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: extend feature flags description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 14:23:13 -0000 Hi Pablo, thanks for the information update. I am ok with this patch, excep= t for one cosmetic change shared inline to previous email otherwise ACK fro= m segmentation. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, May 18, 2018 6:50 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] cryptodev: extend feature flags description >=20 > Extend the description of cryptodev feature flags, adding extra informati= on. >=20 > Signed-off-by: Pablo de Lara > --- > lib/librte_cryptodev/rte_cryptodev.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index 261a359dc..eeb51afac 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -373,7 +373,9 @@ struct rte_cryptodev_info { > uint8_t driver_id; /**< Driver identifier */ > struct rte_pci_device *pci_dev; /**< PCI information. */ >=20 > - uint64_t feature_flags; /**< Feature flags */ > + uint64_t feature_flags; > + /**< Feature flags exposes for the given device its > + * HW/SW offload features. */ Can we slightly rephrase as "exposes offload HW|SW features for the given d= evice" as "feature flags" will be header? >=20 > const struct rte_cryptodev_capabilities *capabilities; > /**< Array of devices supported capabilities */ > -- > 2.17.0