* [dpdk-dev] [PATCH] cryptodev: extend feature flags description
@ 2018-05-18 13:20 Pablo de Lara
2018-05-18 14:23 ` Varghese, Vipin
2018-05-18 16:40 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 2 replies; 6+ messages in thread
From: Pablo de Lara @ 2018-05-18 13:20 UTC (permalink / raw)
To: declan.doherty; +Cc: dev, Pablo de Lara
Extend the description of cryptodev feature flags,
adding extra information.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..eeb51afac 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -373,7 +373,9 @@ struct rte_cryptodev_info {
uint8_t driver_id; /**< Driver identifier */
struct rte_pci_device *pci_dev; /**< PCI information. */
- uint64_t feature_flags; /**< Feature flags */
+ uint64_t feature_flags;
+ /**< Feature flags exposes for the given device its
+ * HW/SW offload features. */
const struct rte_cryptodev_capabilities *capabilities;
/**< Array of devices supported capabilities */
--
2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: extend feature flags description
2018-05-18 13:20 [dpdk-dev] [PATCH] cryptodev: extend feature flags description Pablo de Lara
@ 2018-05-18 14:23 ` Varghese, Vipin
2018-05-18 16:40 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
1 sibling, 0 replies; 6+ messages in thread
From: Varghese, Vipin @ 2018-05-18 14:23 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo
Hi Pablo, thanks for the information update. I am ok with this patch, except for one cosmetic change shared inline to previous email otherwise ACK from segmentation.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, May 18, 2018 6:50 PM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] cryptodev: extend feature flags description
>
> Extend the description of cryptodev feature flags, adding extra information.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index 261a359dc..eeb51afac 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -373,7 +373,9 @@ struct rte_cryptodev_info {
> uint8_t driver_id; /**< Driver identifier */
> struct rte_pci_device *pci_dev; /**< PCI information. */
>
> - uint64_t feature_flags; /**< Feature flags */
> + uint64_t feature_flags;
> + /**< Feature flags exposes for the given device its
> + * HW/SW offload features. */
Can we slightly rephrase as "exposes offload HW|SW features for the given device" as "feature flags" will be header?
>
> const struct rte_cryptodev_capabilities *capabilities;
> /**< Array of devices supported capabilities */
> --
> 2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
2018-05-18 13:20 [dpdk-dev] [PATCH] cryptodev: extend feature flags description Pablo de Lara
2018-05-18 14:23 ` Varghese, Vipin
@ 2018-05-18 16:40 ` Pablo de Lara
2018-05-21 10:13 ` Varghese, Vipin
2018-05-21 11:35 ` Akhil Goyal
1 sibling, 2 replies; 6+ messages in thread
From: Pablo de Lara @ 2018-05-18 16:40 UTC (permalink / raw)
To: vipin.varghese, declan.doherty; +Cc: dev, Pablo de Lara
Extend the description of cryptodev feature flags,
adding extra information.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:
- Rephrased the comment as per Vipin's comments
- Added comment in cryptodev structure
lib/librte_cryptodev/rte_cryptodev.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..2fb65638d 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -373,7 +373,8 @@ struct rte_cryptodev_info {
uint8_t driver_id; /**< Driver identifier */
struct rte_pci_device *pci_dev; /**< PCI information. */
- uint64_t feature_flags; /**< Feature flags */
+ uint64_t feature_flags;
+ /**< Feature flags exposes HW/SW features for the given device */
const struct rte_cryptodev_capabilities *capabilities;
/**< Array of devices supported capabilities */
@@ -749,7 +750,7 @@ struct rte_cryptodev {
struct rte_cryptodev_ops *dev_ops;
/**< Functions exported by PMD */
uint64_t feature_flags;
- /**< Supported features */
+ /**< Feature flags exposes HW/SW features for the given device */
struct rte_device *device;
/**< Backing device */
--
2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
2018-05-18 16:40 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2018-05-21 10:13 ` Varghese, Vipin
2018-05-21 11:35 ` Akhil Goyal
1 sibling, 0 replies; 6+ messages in thread
From: Varghese, Vipin @ 2018-05-21 10:13 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev
Acked-by: Vipin Varghese <vipin.varghese@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, May 18, 2018 10:10 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2] cryptodev: extend feature flags description
>
> Extend the description of cryptodev feature flags, adding extra information.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
> Changes in v2:
> - Rephrased the comment as per Vipin's comments
> - Added comment in cryptodev structure
>
> lib/librte_cryptodev/rte_cryptodev.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index 261a359dc..2fb65638d 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -373,7 +373,8 @@ struct rte_cryptodev_info {
> uint8_t driver_id; /**< Driver identifier */
> struct rte_pci_device *pci_dev; /**< PCI information. */
>
> - uint64_t feature_flags; /**< Feature flags */
> + uint64_t feature_flags;
> + /**< Feature flags exposes HW/SW features for the given device */
>
> const struct rte_cryptodev_capabilities *capabilities;
> /**< Array of devices supported capabilities */ @@ -749,7 +750,7 @@
> struct rte_cryptodev {
> struct rte_cryptodev_ops *dev_ops;
> /**< Functions exported by PMD */
> uint64_t feature_flags;
> - /**< Supported features */
> + /**< Feature flags exposes HW/SW features for the given device */
> struct rte_device *device;
> /**< Backing device */
>
> --
> 2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
2018-05-18 16:40 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-05-21 10:13 ` Varghese, Vipin
@ 2018-05-21 11:35 ` Akhil Goyal
2018-05-21 21:45 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2018-05-21 11:35 UTC (permalink / raw)
To: Pablo de Lara, vipin.varghese, declan.doherty; +Cc: dev
On 5/18/2018 10:10 PM, Pablo de Lara wrote:
> Extend the description of cryptodev feature flags,
> adding extra information.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
2018-05-21 11:35 ` Akhil Goyal
@ 2018-05-21 21:45 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-21 21:45 UTC (permalink / raw)
To: Akhil Goyal, Varghese, Vipin, Doherty, Declan; +Cc: dev
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Monday, May 21, 2018 12:36 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>; Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
>
> On 5/18/2018 10:10 PM, Pablo de Lara wrote:
> > Extend the description of cryptodev feature flags, adding extra
> > information.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-21 21:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 13:20 [dpdk-dev] [PATCH] cryptodev: extend feature flags description Pablo de Lara
2018-05-18 14:23 ` Varghese, Vipin
2018-05-18 16:40 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-05-21 10:13 ` Varghese, Vipin
2018-05-21 11:35 ` Akhil Goyal
2018-05-21 21:45 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).