From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A6933D00F for ; Mon, 21 May 2018 12:13:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 03:13:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="57654294" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 21 May 2018 03:13:51 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 03:13:51 -0700 Received: from bgsmsx103.gar.corp.intel.com (10.223.4.130) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 03:13:50 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.244]) by BGSMSX103.gar.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0319.002; Mon, 21 May 2018 15:43:48 +0530 From: "Varghese, Vipin" To: "De Lara Guarch, Pablo" , "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] cryptodev: extend feature flags description Thread-Index: AQHT7scZ5Sdi015KfkCBpszfMFy1KaQ5+yow Date: Mon, 21 May 2018 10:13:47 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BE7@BGSMSX101.gar.corp.intel.com> References: <20180518132007.5401-1-pablo.de.lara.guarch@intel.com> <20180518164018.2576-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180518164018.2576-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmY0N2M4YWItYjU3ZS00ZWM1LThmNTMtNmUyMzExOWEwMDA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWWc5b2tkajlneXk3aVpGbVJWK3N4ZFwvWVFCS3hEa3orbWE2UGV5bXVwZnNMM0JaTXBzV0ZOaVwvVXRvbm9CbWtJIn0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 10:13:55 -0000 Acked-by: Vipin Varghese > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, May 18, 2018 10:10 PM > To: Varghese, Vipin ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2] cryptodev: extend feature flags description >=20 > Extend the description of cryptodev feature flags, adding extra informati= on. >=20 > Signed-off-by: Pablo de Lara > --- >=20 > Changes in v2: > - Rephrased the comment as per Vipin's comments > - Added comment in cryptodev structure >=20 > lib/librte_cryptodev/rte_cryptodev.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index 261a359dc..2fb65638d 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -373,7 +373,8 @@ struct rte_cryptodev_info { > uint8_t driver_id; /**< Driver identifier */ > struct rte_pci_device *pci_dev; /**< PCI information. */ >=20 > - uint64_t feature_flags; /**< Feature flags */ > + uint64_t feature_flags; > + /**< Feature flags exposes HW/SW features for the given device */ >=20 > const struct rte_cryptodev_capabilities *capabilities; > /**< Array of devices supported capabilities */ @@ -749,7 +750,7 @@ > struct rte_cryptodev { > struct rte_cryptodev_ops *dev_ops; > /**< Functions exported by PMD */ > uint64_t feature_flags; > - /**< Supported features */ > + /**< Feature flags exposes HW/SW features for the given device */ > struct rte_device *device; > /**< Backing device */ >=20 > -- > 2.17.0