From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EFE78235 for ; Wed, 23 May 2018 06:37:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 21:37:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,431,1520924400"; d="scan'208";a="43482588" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 22 May 2018 21:37:40 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 21:37:37 -0700 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 21:37:37 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.244]) by BGSMSX108.gar.corp.intel.com ([169.254.8.91]) with mapi id 14.03.0319.002; Wed, 23 May 2018 10:07:32 +0530 From: "Varghese, Vipin" To: Ophir Munk , "dev@dpdk.org" , "Yigit, Ferruh" , "Wiles, Keith" CC: Thomas Monjalon , Olga Shern Thread-Topic: [PATCH v3] net/tap: perform proto field update for tun only Thread-Index: AQHT8bpBrq77U1KF60qX+4/ksZtYsqQ7fLgAgAE+LzA= Date: Wed, 23 May 2018 04:37:31 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F880F@BGSMSX101.gar.corp.intel.com> References: <1526395780-105792-1-git-send-email-vipin.varghese@intel.com> <1526986034-2862-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjYyNTQ4YzgtMThkZi00ZDVmLTk3ODQtMjFiZTM3MWMxYmZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZTlmN3hDTFZxaFhrR1paKzV0M1phSUt4cFhNVHdQUXM2YmFZaTBJdGU1MVVVVVNzQmR2TDh3RGFhM1Y5NmkydyJ9 dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/tap: perform proto field update for tun only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 04:37:43 -0000 Hi Ophir, Thanks for inputs, please find my answers inline to the mail > -----Original Message----- > From: Ophir Munk [mailto:ophirmu@mellanox.com] > Sent: Tuesday, May 22, 2018 8:35 PM > To: Varghese, Vipin ; dev@dpdk.org; Yigit, Ferr= uh > ; Wiles, Keith > Cc: Thomas Monjalon ; Olga Shern > > Subject: RE: [PATCH v3] net/tap: perform proto field update for tun only >=20 > Hi, > Overall it looks good. > Please note a few more comments below. >=20 > > -----Original Message----- > > From: Vipin Varghese [mailto:vipin.varghese@intel.com] > > Sent: Tuesday, May 22, 2018 1:47 PM > > To: dev@dpdk.org; ferruh.yigit@intel.com; keith.wiles@intel.com; Ophir > > Munk > > Cc: Thomas Monjalon ; Olga Shern > > ; Vipin Varghese > > Subject: [PATCH v3] net/tap: perform proto field update for tun only > > > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > > type field will ensure the TAP PMD will always have protocol field as 0= . > > > > Signed-off-by: Vipin Varghese > > Suggested-by: Ferruh Yigit > > --- >=20 > Shouldn't it be a fix commit? The following code base is not merged with stable, dev or next-net branch. = Hence do we 'fix commit' this? > If so - please update the commit title, add Fixes: ... , Cc: stable@dpdk.= org... >=20 > > Changes in V3: > > - remove type field from rx struct - Ophir Munk > > - add space for comment in struct - Ophir Munk > > - pass type field into eth_dev_tap_create - Ophir Munk > > - replace with enum value for type - Ophir Munk > > - return as 'not supported' for mac_set - Vipin Varghese > > > > Changes in V2: > > - updated in comment wording - Keith Wiles > > - remove debug print from tx code - Keith Wiles > > --- > > drivers/net/tap/rte_eth_tap.c | 61 > > +++++++++++++++++++++++++------------- > > ----- > > drivers/net/tap/rte_eth_tap.h | 9 +++++++ > > 2 files changed, 45 insertions(+), 25 deletions(-) > > > > > > + if (pmd->type =3D=3D ETH_TUNTAP_TYPE_TUN) > > + return -ENOTSUP; >=20 >=20 > Can you please add a TAP_LOG(ERR, ...) to log this error similar to other= error > cases in this function? Yes, I will add the change in v4 and share the same. >=20 > > +