From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 259F82965 for ; Sat, 20 Oct 2018 16:10:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2018 07:10:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,404,1534834800"; d="scan'208";a="100917560" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 20 Oct 2018 07:10:34 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 20 Oct 2018 07:10:34 -0700 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 20 Oct 2018 07:10:33 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.39]) by BGSMSX151.gar.corp.intel.com ([169.254.3.90]) with mapi id 14.03.0319.002; Sat, 20 Oct 2018 19:40:30 +0530 From: "Varghese, Vipin" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Byrne, Stephen1" Thread-Topic: [PATCH] doc/qos_meter: update application information Thread-Index: AQHUYjTsk4sucVfSn0ywnC5d2Q/t6KUgHh4AgAgaXIA= Date: Sat, 20 Oct 2018 14:10:30 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2A2798@BGSMSX101.gar.corp.intel.com> References: <20181012140337.22570-1-vipin.varghese@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7D9C4C@IRSMSX107.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7D9C4C@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M0NDM5NTUtNGNkOS00ZjQ0LTg2ZTctNDUxM2EyMTAzMzU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaE5YbDZMQ0wwanhjQUYrTXNTRkRcLzF1M3RrTTlpTkE5c2hzVklsN2NsWTFpVUdjTkFGWEduQzlzQ2x0bkREaFgifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc/qos_meter: update application information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 14:10:36 -0000 Hi Cristian, If rewording for 0 to GREEN was required option 'changes requested' would h= ave been set. But since the state is been set to 'Rejected' I am confused w= hat are the comments requesting for GREEN? Thanks Vipin Varghese > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Monday, October 15, 2018 9:25 PM > To: Varghese, Vipin ; dev@dpdk.org; Singh, > Jasvinder > Cc: Byrne, Stephen1 > Subject: RE: [PATCH] doc/qos_meter: update application information >=20 >=20 >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Friday, October 12, 2018 3:04 PM > > To: dev@dpdk.org; Dumitrescu, Cristian > > ; Singh, Jasvinder > > > > Cc: Byrne, Stephen1 ; Varghese, Vipin > > > > Subject: [PATCH] doc/qos_meter: update application information > > > > THe change adds special note for colour blind and porfile_table > > actions. In colour blind mode, the previous colour value is always 0. > > For DROP action, one needs to edit the profile_table entries > > apporpiately. > > > > Signed-off-by: Vipin Varghese > > --- > > doc/guides/sample_app_ug/qos_metering.rst | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/doc/guides/sample_app_ug/qos_metering.rst > > b/doc/guides/sample_app_ug/qos_metering.rst > > index 6391841c6..1ec94b0b3 100644 > > --- a/doc/guides/sample_app_ug/qos_metering.rst > > +++ b/doc/guides/sample_app_ug/qos_metering.rst > > @@ -149,3 +149,8 @@ In this particular case: > > * Every packet which color has improved is dropped (this particular = case > > can't happen, so these values will not be used). > > > > * For the rest of the cases, the color is changed to red. > > + > > + > > +.. note:: > > + * In color blind mode, first row is only valid as previous colour is = 0. >=20 > Available colors are GREEN, YELLOW and RED, the color is not encoded with= a > numeric value such as 0. You might want to say GREEN? >=20 > > + * To drop the packet, policer_table action has to be set to DROP. > > -- > > 2.17.1