From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <vipin.varghese@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7D11F1B55D for <dev@dpdk.org>; Fri, 23 Nov 2018 14:55:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2018 05:55:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="108718068" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 23 Nov 2018 05:55:43 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 05:55:43 -0800 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 05:55:42 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX106.gar.corp.intel.com ([169.254.1.107]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 19:25:39 +0530 From: "Varghese, Vipin" <vipin.varghese@intel.com> To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "Mcnamara, John" <john.mcnamara@intel.com> CC: "Byrne, Stephen1" <stephen1.byrne@intel.com>, "Glynn, Michael J" <michael.j.glynn@intel.com>, "Patel, Amol" <amol.patel@intel.com> Thread-Topic: [PATCH v4 5/9] app/procinfo: add support for show tm Thread-Index: AQHUdc+zPfVf/p7zD0i8dNfiuPEpQaVaBQMAgAHdNJCAARuHAIAAdxGA//+lqACAAGIkoA== Date: Fri, 23 Nov 2018 13:55:39 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A79@BGSMSX101.gar.corp.intel.com> References: <20181106124912.40700-1-vipin.varghese@intel.com> <20181106124912.40700-5-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D58A3@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1435@BGSMSX101.gar.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D61A6@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A45@BGSMSX101.gar.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D6264@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3D6264@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Q5MmRlYjMtMDM5OS00M2FmLWI2MmEtNDRiNjg5OWU3OWI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidjVPTDVwN1NhYVAzRzB1QUQxYUZPVWk1V21aejhVQUxJWXd1QlJnWWVcL2RlU1VRcGZTZVpJTDFYSXdacXF0T1cifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 23 Nov 2018 13:55:45 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Friday, November 23, 2018 7:04 PM > To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; > thomas@monjalon.net; stephen@networkplumber.org; Mcnamara, John > <john.mcnamara@intel.com> > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Glynn, Michael J > <michael.j.glynn@intel.com>; Patel, Amol <amol.patel@intel.com> > Subject: RE: [PATCH v4 5/9] app/procinfo: add support for show tm >=20 >=20 >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Friday, November 23, 2018 1:29 PM > > To: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org; > > thomas@monjalon.net; stephen@networkplumber.org; Mcnamara, John > > <john.mcnamara@intel.com> > > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Glynn, Michael J > > <michael.j.glynn@intel.com>; Patel, Amol <amol.patel@intel.com> > > Subject: RE: [PATCH v4 5/9] app/procinfo: add support for show tm > > > > > > > -----Original Message----- > > > From: Pattan, Reshma > > > Sent: Friday, November 23, 2018 5:21 PM > > > To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; > > > thomas@monjalon.net; stephen@networkplumber.org; Mcnamara, John > > > <john.mcnamara@intel.com> > > > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Glynn, Michael J > > > <michael.j.glynn@intel.com>; Patel, Amol <amol.patel@intel.com> > > > Subject: RE: [PATCH v4 5/9] app/procinfo: add support for show tm > > > > > > > > > > > > > -----Original Message----- > > > > From: Varghese, Vipin > > > > Sent: Thursday, November 22, 2018 1:28 PM > > > > To: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org; > > > > thomas@monjalon.net; stephen@networkplumber.org; Mcnamara, John > > > > <john.mcnamara@intel.com> > > > > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Glynn, Michael J > > > > <michael.j.glynn@intel.com>; Patel, Amol <amol.patel@intel.com> > > > > Subject: RE: [PATCH v4 5/9] app/procinfo: add support for show tm > > > > > > > > Hi Reshma, > > > > > > > > <snipped> > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > + > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > Check is done for 'if either ret is not 0 or if it ret is 0 but > > > > not leaf' we skip leaf details print. If 'ret is 0 and is leaf' we > > > > skip continue to print > > > leaf details. > > > > > > IMO, using logical operator over bitwise operator is good here in if > > > statement > > . > > > Like below.? > > > > > > If (ret || (is_leaf =3D=3D 0 )) > > > > Thanks for the information, if the logic is correct do I need to > > change for v6 > > >=20 > OK in v6, but you can wait to hear more comments from others if any befor= e > sending v6 . Ok thanks Reshma, but can you tell me how the earlier logic fails and runs = slow compared to logical or?