From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 601DF1B540 for ; Fri, 23 Nov 2018 16:10:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2018 07:10:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="98494478" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 23 Nov 2018 07:10:56 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 07:10:56 -0800 Received: from bgsmsx110.gar.corp.intel.com (10.223.4.212) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 07:10:56 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX110.gar.corp.intel.com ([169.254.11.69]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 20:40:52 +0530 From: "Varghese, Vipin" To: "Jozwiak, TomaszX" , "dev@dpdk.org" , "Trahe, Fiona" , "Jozwiak, TomaszX" , "Shally.Verma@cavium.com" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser Thread-Index: AQHUgzjTzOUBLbueJES84kzEdG+rCaVddgbw Date: Fri, 23 Nov 2018 15:10:51 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B41@BGSMSX101.gar.corp.intel.com> References: <1542978409-28668-1-git-send-email-tomaszx.jozwiak@intel.com> <1542983269-30093-1-git-send-email-tomaszx.jozwiak@intel.com> <1542983269-30093-2-git-send-email-tomaszx.jozwiak@intel.com> In-Reply-To: <1542983269-30093-2-git-send-email-tomaszx.jozwiak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRhOTQ2ZDAtYWIxYi00NmVhLWJlMTItYTIxMWY1ZjI5N2U0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMGt0XC9id0J2R05ya2VneklcL29TN2VzOE5yMFMxWGZOdVhQeVhBbGRiWTBaQ0RkSlRianU5bGRpbU5weUtJc3pmIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 15:10:57 -0000 > +#define MAX_DRIVER_NAME 64 > +#define MAX_INPUT_FILE_NAME 64 > +comp_perf_options_check(struct comp_test_data *test_data) { > + if (strcmp(test_data->driver_name, "") =3D=3D 0) { Should we use strncmp for boundary? > + RTE_LOG(ERR, USER1, "Driver name has to be set\n"); > + return -1; > + } > + > + if (strcmp(test_data->input_file, "") =3D=3D 0) { Should we use strncmp for boundary? > + RTE_LOG(ERR, USER1, "Input file name has to be set\n"); > + return -1; > + } > + > + test_data =3D rte_zmalloc_socket(NULL, sizeof(struct comp_test_data), > + 0, rte_socket_id()); Suggestion: if the PMD is socket specific, do we need to alloc socket speci= fic too? (assuming HW or SW socket specific PMD can be used)