From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D8DEB1B5E4 for ; Mon, 26 Nov 2018 04:58:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2018 19:58:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,280,1539673200"; d="scan'208";a="252544241" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 25 Nov 2018 19:58:50 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 25 Nov 2018 19:58:50 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 25 Nov 2018 19:58:49 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX107.gar.corp.intel.com ([169.254.9.55]) with mapi id 14.03.0415.000; Mon, 26 Nov 2018 09:28:46 +0530 From: "Varghese, Vipin" To: "Yang, Qiming" , "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting Thread-Index: AQHUgvk6DESCMJBg80ynJa4HddNgaqVdH4cQgAPxVACAAGBMkA== Date: Mon, 26 Nov 2018 03:58:45 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1F9A@BGSMSX101.gar.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1542956179-80951-8-git-send-email-wenzhuo.lu@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1918@BGSMSX101.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGU5YmY3M2ItMTBmZi00NTBlLWJlNWUtNTgyMDc1ODNlZDZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY2dyVVoyVzNYYzR0SmFhVTZBVHcxQjc5TzJ1YmNQcCtjdStuRXRiTnpabzdTcWVIMFVFc2xpbUk4N2tMTnlPOSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 03:58:52 -0000 Hi Qiming > -----Original Message----- > From: Yang, Qiming > Sent: Monday, November 26, 2018 9:09 AM > To: Varghese, Vipin ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Li, Xiaoyun ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting >=20 > Hi, Vipin > Not sure understand your question. > We have no need to configure jumbo frame, because jumbo frame offload wil= l be > enable when mtu>1500. Apologies if the question is not clear. Let me try to explain what I am try= ing to ask below >=20 > Qiming > -----Original Message----- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 5:58 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting >=20 > HI Wenzhou, >=20 > Following is a thought but not an issue. Can you please let me know your > thought? >=20 > >=20 > > +static int > > +ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > + struct rte_eth_dev_data *dev_data =3D pf->dev_data; > > + uint32_t frame_size =3D mtu + ETHER_HDR_LEN > > + + ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE; > > + > > + if (rte_eal_process_type() =3D=3D RTE_PROC_SECONDARY) > > + return -E_RTE_SECONDARY; > > + > > + /* check if mtu is within the allowed range */ > > + if ((mtu < ETHER_MIN_MTU) || (frame_size > ICE_FRAME_SIZE_MAX)) > > + return -EINVAL; > > + >=20 > Should we set MTU > 1500 (Jumbo frame) if device is not configured to run= with > jumbo frame? If no, should we check the jumbo config is enabled for the c= urrent > device? >=20 1. If by default JUMBO enabled for this device? 2. There is RX offload which is configured with value 'DEV_RX_OFFLOAD_JUMBO= _FRAME'. Should this be enabled for supporting JUMBO frames? 3. There is per RX queue offload flag too 'DEV_RX_OFFLOAD_JUMBO_FRAME'. If = port_conf is set for 'DEV_RX_OFFLOAD_JUMBO_FRAME' but disabled for specific= RX queue 'DEV_RX_OFFLOAD_JUMBO_FRAME', what is the JUMBO setting for the d= evice? Hence do we need to check 'mtu_set' for whether actually device is configur= ed for JUMBO processing or not? > > + /* mtu setting is forbidden if port is start */ > > + if (dev_data->dev_started) { > > + PMD_DRV_LOG(ERR, > > + "port %d must be stopped before configuration", > > + dev_data->port_id); > > + return -EBUSY; > > + } > > + > > + if (frame_size > ETHER_MAX_LEN) > > + dev_data->dev_conf.rxmode.offloads |=3D > > + DEV_RX_OFFLOAD_JUMBO_FRAME; > > + else > > + dev_data->dev_conf.rxmode.offloads &=3D > > + ~DEV_RX_OFFLOAD_JUMBO_FRAME; > > + > > + dev_data->dev_conf.rxmode.max_rx_pkt_len =3D frame_size; > > + > > + return 0; > > +} > > -- > > 1.9.3