DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "thomas@monjalon.net" <thomas@monjalon.net>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Byrne, Stephen1" <stephen1.byrne@intel.com>,
	"Glynn, Michael J" <michael.j.glynn@intel.com>,
	"Patel, Amol" <amol.patel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm
Date: Mon, 26 Nov 2018 10:13:52 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C222C@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010CEBC536@IRSMSX106.ger.corp.intel.com>

Hi,

> Hi Vipin,
> 
> >
> > Hi Konstantin,
> >
> > > >
> > > > If the operator is '|' what else except of 'OR' you expect it to be remapped?
> >
> > Thanks for your correction. I have rerun with logical or
> >
> >                         if ((ret) || (!is_leaf))
> >    9a512:       83 bd 3c fd ff ff 00    cmp    DWORD PTR [rbp-0x2c4],0x0
> >    9a519:       75 7e                   jne    9a599 <show_tm+0x739>
> >    9a51b:       8b 85 28 fd ff ff       mov    eax,DWORD PTR [rbp-0x2d8]
> >    9a521:       85 c0                   test   eax,eax
> >    9a523:       74 74                   je     9a599 <show_tm+0x739>
> >                                 continue;
> >
> > There is no conversion to 'Or' operation here. Thanks for
> >
> > > BTW, I am agree with Reshma it has to be '||' here.
> > Thanks for your opinion, can you share review comments for show_tm for
> debug?
> 
> Not sure I understand your last sentence...
> Konstantin

As mentioned earlier email I am ready to spin v6 with 'logical or'. But if there any other comments for show_tm it will be nice to accommodate to v6 rather than v7. So, can you please share if there any other comments for show_tm?

Thanks
Vipin Varghese

  reply	other threads:[~2018-11-26 10:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 12:49 [dpdk-dev] [PATCH v4 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 4/9] app/procinfo: add support for show port Vipin Varghese
2018-11-21 14:24   ` Pattan, Reshma
2018-11-22 14:20     ` Varghese, Vipin
2018-11-21 20:22   ` Stephen Hemminger
2018-11-22 14:21     ` Varghese, Vipin
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-11-21 14:28   ` Pattan, Reshma
2018-11-22 13:28     ` Varghese, Vipin
2018-11-23 11:50       ` Pattan, Reshma
2018-11-23 13:29         ` Varghese, Vipin
2018-11-23 13:33           ` Pattan, Reshma
2018-11-23 13:55             ` Varghese, Vipin
2018-11-23 14:57               ` Pattan, Reshma
2018-11-23 15:05                 ` Varghese, Vipin
2018-11-23 17:22                   ` Stephen Hemminger
2018-11-26  4:15                     ` Varghese, Vipin
2018-11-26  9:28                       ` Ananyev, Konstantin
2018-11-26  9:33                         ` Ananyev, Konstantin
2018-11-26  9:46                           ` Varghese, Vipin
2018-11-26  9:56                             ` Ananyev, Konstantin
2018-11-26 10:13                               ` Varghese, Vipin [this message]
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 8/9] app/procinfo: add support for show mempool Vipin Varghese
2018-11-21 17:23   ` Pattan, Reshma
2018-11-22 14:21     ` Varghese, Vipin
2018-11-06 12:49 ` [dpdk-dev] [PATCH v4 9/9] doc/procinfo: add information for debug options Vipin Varghese
  -- strict thread matches above, loose matches on Subject: below --
2018-11-06  2:34 [dpdk-dev] [PATCH v4 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-11-06  2:34 ` [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm Vipin Varghese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C222C@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=amol.patel@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=michael.j.glynn@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stephen1.byrne@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).