From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2618D1B3BB for ; Tue, 4 Dec 2018 05:53:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2018 20:53:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,312,1539673200"; d="scan'208";a="280716809" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 03 Dec 2018 20:53:13 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Dec 2018 20:53:13 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Dec 2018 20:53:12 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX102.gar.corp.intel.com ([169.254.2.133]) with mapi id 14.03.0415.000; Tue, 4 Dec 2018 10:23:09 +0530 From: "Varghese, Vipin" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue ops Thread-Index: AQHUitZa3WDepqqcYku9GRSOAQaFWKVuAf8A Date: Tue, 4 Dec 2018 04:53:08 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4550@BGSMSX101.gar.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-4-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1543820821-108122-4-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGE3MjlkNDUtZDQ0Mi00YmYwLTljYjgtMTRiNDM2MzkzNWUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRmxGaXh2d3B6RlY4T2lpd2g0dDd2eThkVHpSb01ZTWhGZ1l5S3BRR1A4RXB4UTY5dkZRempIbGt4VEdOdHRPWCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 04:53:15 -0000 snipped > + > +static int ice_init_rss(struct ice_pf *pf) { > + struct ice_hw *hw =3D ICE_PF_TO_HW(pf); > + struct ice_vsi *vsi =3D pf->main_vsi; > + struct rte_eth_dev *dev =3D pf->adapter->eth_dev; > + struct rte_eth_rss_conf *rss_conf; > + struct ice_aqc_get_set_rss_keys key; > + uint16_t i, nb_q; > + int ret =3D 0; > + > + rss_conf =3D &dev->data->dev_conf.rx_adv_conf.rss_conf; > + nb_q =3D dev->data->nb_rx_queues; > + vsi->rss_key_size =3D ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE; > + vsi->rss_lut_size =3D hw->func_caps.common_cap.rss_table_size; > + > + if (!vsi->rss_key) > + vsi->rss_key =3D rte_zmalloc("rss_key", > + vsi->rss_key_size, 0); > + if (!vsi->rss_lut) > + vsi->rss_lut =3D rte_zmalloc("rss_lut", > + vsi->rss_lut_size, 0); 2 suggestions 1. should the name be macro? 2. if there are multiple 810 NIC under DPDK, should not each rss be differe= nt like "rss_key-%u" where it is port number? Snipped > + > +static int > +ice_dev_start(struct rte_eth_dev *dev) > +{ > + struct rte_eth_dev_data *data =3D dev->data; > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + uint16_t nb_rxq =3D 0; > + uint16_t nb_txq, i; > + int ret; > + > + ICE_PROC_SECONDARY_CHECK; Device start is not supported, but how is this differentiated from primary = configured device vs secondary configured device. Ie: primary uses black list '-b BB:DD:F' while secondary uses '-w BB:DD:F'.= In this case since we are checking process type this will return without s= tart? Snipped > + > +static void > +ice_dev_stop(struct rte_eth_dev *dev) > +{ > + struct rte_eth_dev_data *data =3D dev->data; > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + uint16_t i; > + > + /* avoid stopping again */ > + if (pf->adapter_stopped) > + return; > + > + ICE_PROC_SECONDARY_CHECK_NO_ERR; Same as above. snipped