From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 6CD455F72 for ; Thu, 6 Dec 2018 06:26:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 21:26:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,321,1539673200"; d="scan'208";a="116073570" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 05 Dec 2018 21:26:53 -0800 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Dec 2018 21:26:53 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX151.gar.corp.intel.com ([169.254.3.166]) with mapi id 14.03.0415.000; Thu, 6 Dec 2018 10:56:50 +0530 From: "Varghese, Vipin" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue ops Thread-Index: AQHUitZa3WDepqqcYku9GRSOAQaFWKVuAf8AgALOOoCAAGDQ4A== Date: Thu, 6 Dec 2018 05:26:50 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D4171@BGSMSX101.gar.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-4-git-send-email-wenzhuo.lu@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4550@BGSMSX101.gar.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093FE11691@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE11691@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODAzODA1ZGMtOTliZi00Mjc1LTg4ZWQtMDg2MGFhZGE4MDkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0NXenhxY0hPWlY3VlkxM3RNR3NHTzZ1cXJQMFZOdFJ4WFlhZG9MSFNJMDh4MmR3ZjJBMENUWmhxSit1U1ExdiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 05:26:56 -0000 Hi Wenzhuo, Please find my updates below snipped > > > + if (!vsi->rss_key) > > > + vsi->rss_key =3D rte_zmalloc("rss_key", > > > + vsi->rss_key_size, 0); > > > + if (!vsi->rss_lut) > > > + vsi->rss_lut =3D rte_zmalloc("rss_lut", > > > + vsi->rss_lut_size, 0); > > > > 2 suggestions > > 1. should the name be macro? > Sorry, which name? Would you like to convert and use as?=20 #define ICE_RSS_KEY "rss_key" #define ICE_RSS_LUT "rss_lut" And replace ' rte_zmalloc("rss_key",' as ' rte_zmalloc(ICE_RSS_KEY,' >=20 > > 2. if there are multiple 810 NIC under DPDK, should not each rss be > > different like "rss_key-%u" where it is port number? > Sorry, don't understand the question. Let assume we have 2 ICE_DSI NIC on PCIe bus. Then crating ' rte_zmalloc("r= ss_key",' for port 1 will fail since malloc region "rss_key" already exist = for port 0 >=20 > > > > Snipped > > > > > + > > > +static int > > > +ice_dev_start(struct rte_eth_dev *dev) { > > > + struct rte_eth_dev_data *data =3D dev->data; > > > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > > > >dev_private); > > > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data- > > >dev_private); > > > + uint16_t nb_rxq =3D 0; > > > + uint16_t nb_txq, i; > > > + int ret; > > > + > > > + ICE_PROC_SECONDARY_CHECK; > > > > Device start is not supported, but how is this differentiated from > > primary configured device vs secondary configured device. > > > > Ie: primary uses black list '-b BB:DD:F' while secondary uses '-w > > BB:DD:F'. In this case since we are checking process type this will ret= urn without > start? Two updates with respect to your comment,=20 1. tool and application like dpdk-procinfo will no longer be able pull data= since you are asking to black list. 2. If there are functions which needs to shared, like primary using rx-0 an= d tx-0 then secondary rx-1 and tx-1 how to make this work? snipped