From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1A4E92B9A for ; Thu, 6 Dec 2018 06:51:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 21:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,321,1539673200"; d="scan'208";a="301468916" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 05 Dec 2018 21:51:00 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Dec 2018 21:51:00 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX102.gar.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0415.000; Thu, 6 Dec 2018 11:20:57 +0530 From: "Varghese, Vipin" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics Thread-Index: AQHUitafEVEyK8T9QE6K+vPb1MHgQ6VuECgAgALJn4CAAF+IsA== Date: Thu, 6 Dec 2018 05:50:57 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D41E4@BGSMSX101.gar.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-1-git-send-email-wenzhuo.lu@intel.com> <1543820821-108122-15-git-send-email-wenzhuo.lu@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C45C3@BGSMSX101.gar.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093FE11706@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE11706@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzAxOTIxNTUtODQ2NC00Y2NhLWIyMGUtMTI5NWVjNTdmYzZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZzB4RU1oY2wrMUJjK3FPbGhpQkNoRFF5Zmx1d1UxVDl5T0RGcGFCWFNHdlJucGFzQjBKVlBrSUlzdjNudlVIVCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 05:51:02 -0000 Snipped > > > > snipped > > > + ns->eth.tx_bytes -=3D (ns->eth.tx_unicast + ns->eth.tx_multicast + > > > + ns->eth.tx_broadcast) * ETHER_CRC_LEN; > > > > In earlier patch for 'mtu set check' we added VSI SWITCH VLAN. Should > > we add VSI VLAN here? > Don't need. They're different functions. We add crc length here because o= f HW > counts the packet length before crc is added. So you are not fetching stats from HW registers from switch is this correct= ? How will you get stats for actually transmitted in xstats? As I understan= d xstats is for switch HW stats right? >=20 >=20 > > snipped