From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, John Daley <johndale@cisco.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic
Date: Tue, 11 Dec 2018 16:49:26 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9CB5@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20181211164012.GA25076@HYONKIM-7R0DR.cisco.com>
snipped
> > Hi Hyong,
> >
> > snipped
> > > > Hi Hyong,
> > > >
> > > > Thanks for sharing the information a query 'is ENIC Poll Mode
> > > > Driver is been
> > > updated too?'(Section 16 under Network Interface Controller).
> > > > a. If yes is it ok to link the patchwork in comment section?
> > > > b. If no, will you be updating the documentation?
> > > >
> > >
> > > Vipin,
> > >
> > > I am not planning to update the enic guide, as these changes (fw
> > > version string, multicast filtering) do not need additional
> > > explanations. Did you have something else in mind?
> >
> > Thanks for sharing the information.
> >
> > In my humble opinion
> >
> > In documentation section '16.13. Supported features' states 'Unicast,
> multicast and broadcast transmission and reception'. So multicast 'filtering' to
> be added as supported feature or not is upto the individual for the PMD. But
> as you shared the information ' I am not planning to update the enic guide' I
> will leave this open to others for comment.
>
> I see what you mean now. Sure, I will send another patch to update that
> section later. As is, it is really a duplicate of doc/guides/nics/features. Not sure
> if we want to keep maintaining two copies of the same information.
>
> >
> > Question: Will there update for test cases for mac filtering been added?
> Reason the patch set is not covering test case addition.
> >
>
> We have an internal DTS based test case for multicast filtering. Do we need to
> mention test cases in commit logs now? I am a bit confused where this
> question is coming from..
Apologies if the question was not clear, Let me try again 'Is there plan add test cases under dpdk/test/test folder?'
>
> -Hyong
next prev parent reply other threads:[~2018-12-11 16:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:28 [dpdk-dev] [PATCH 0/4] net/enic: minor updates Hyong Youb Kim
2018-12-10 18:28 ` [dpdk-dev] [PATCH 1/4] net/enic: release port upon close Hyong Youb Kim
2018-12-10 18:28 ` [dpdk-dev] [PATCH 2/4] net/enic: add handler to return firmware version string Hyong Youb Kim
2018-12-10 18:28 ` [dpdk-dev] [PATCH 3/4] net/enic: support multicast filtering Hyong Youb Kim
2019-01-11 15:46 ` Ferruh Yigit
2019-01-12 4:49 ` Hyong Youb Kim
2019-01-14 10:29 ` Ferruh Yigit
2018-12-10 18:28 ` [dpdk-dev] [PATCH 4/4] doc: update release notes for enic Hyong Youb Kim
2018-12-11 2:44 ` Varghese, Vipin
2018-12-11 16:08 ` Hyong Youb Kim
2018-12-11 16:31 ` Varghese, Vipin
2018-12-11 16:40 ` Hyong Youb Kim
2018-12-11 16:49 ` Varghese, Vipin [this message]
2018-12-11 17:25 ` Hyong Youb Kim
2018-12-12 2:23 ` Varghese, Vipin
2018-12-12 11:56 ` [dpdk-dev] [PATCH 0/4] net/enic: minor updates Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9CB5@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).