From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3919C5B30 for ; Tue, 11 Dec 2018 17:49:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 08:49:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,342,1539673200"; d="scan'208";a="126993793" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 11 Dec 2018 08:49:31 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Dec 2018 08:49:31 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Dec 2018 08:49:30 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX102.gar.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0415.000; Tue, 11 Dec 2018 22:19:28 +0530 From: "Varghese, Vipin" To: Hyong Youb Kim CC: "Yigit, Ferruh" , "dev@dpdk.org" , John Daley Thread-Topic: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic Thread-Index: AQHUkLZh0OtmNoqU0k+l3rS6eRsg9KV41OBQgACFB4CAAGDZsP//p/4AgABeiDA= Date: Tue, 11 Dec 2018 16:49:26 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9CB5@BGSMSX101.gar.corp.intel.com> References: <20181210182857.13043-1-hyonkim@cisco.com> <20181210182857.13043-5-hyonkim@cisco.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D98F9@BGSMSX101.gar.corp.intel.com> <20181211160832.GA24424@HYONKIM-7R0DR.cisco.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9C52@BGSMSX101.gar.corp.intel.com> <20181211164012.GA25076@HYONKIM-7R0DR.cisco.com> In-Reply-To: <20181211164012.GA25076@HYONKIM-7R0DR.cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGNmMWRlZTYtNWY4Ni00MGZiLTljNzMtMDg3NTg0M2FhMmU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZUppcWg5TmxxTEM0RWhkb01cL0Z6NVwvMjNFOERSb2ZtMlF5TG9yR2pyckFqWUhXNWg4UW81Z1J1SFhpZWxRUVNqIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 16:49:32 -0000 snipped > > Hi Hyong, > > > > snipped > > > > Hi Hyong, > > > > > > > > Thanks for sharing the information a query 'is ENIC Poll Mode > > > > Driver is been > > > updated too?'(Section 16 under Network Interface Controller). > > > > a. If yes is it ok to link the patchwork in comment section? > > > > b. If no, will you be updating the documentation? > > > > > > > > > > Vipin, > > > > > > I am not planning to update the enic guide, as these changes (fw > > > version string, multicast filtering) do not need additional > > > explanations. Did you have something else in mind? > > > > Thanks for sharing the information. > > > > In my humble opinion > > > > In documentation section '16.13. Supported features' states 'Unicast, > multicast and broadcast transmission and reception'. So multicast 'filter= ing' to > be added as supported feature or not is upto the individual for the PMD. = But > as you shared the information ' I am not planning to update the enic guid= e' I > will leave this open to others for comment. >=20 > I see what you mean now. Sure, I will send another patch to update that > section later. As is, it is really a duplicate of doc/guides/nics/feature= s. Not sure > if we want to keep maintaining two copies of the same information. >=20 > > > > Question: Will there update for test cases for mac filtering been added= ? > Reason the patch set is not covering test case addition. > > >=20 > We have an internal DTS based test case for multicast filtering. Do we ne= ed to > mention test cases in commit logs now? I am a bit confused where this > question is coming from.. Apologies if the question was not clear, Let me try again 'Is there plan ad= d test cases under dpdk/test/test folder?' >=20 > -Hyong