From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8F6E51B1FE for ; Wed, 12 Dec 2018 16:06:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 07:06:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,344,1539673200"; d="scan'208";a="125265516" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 12 Dec 2018 07:06:16 -0800 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 07:06:16 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX151.gar.corp.intel.com ([169.254.3.166]) with mapi id 14.03.0415.000; Wed, 12 Dec 2018 20:36:13 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "dev@dpdk.org" , "Mcnamara, John" CC: "thomas@monjalon.net" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [PATCH v6 1/9] app/procinfo: add usage for new debug Thread-Index: AQHUisyUfC/4KxYzqEuwqiMhe3HeZ6V62E2AgABp46A= Date: Wed, 12 Dec 2018 15:06:13 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DA197@BGSMSX101.gar.corp.intel.com> References: <20181122141543.37067-1-vipin.varghese@intel.com> <20181203055000.39012-1-vipin.varghese@intel.com> <20181203055000.39012-2-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3E9BB8@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3E9BB8@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWFlY2JkNDktMzQxZi00MjdlLWE3MWUtNDMwMGNmNjk5YzE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHRQZ2tIUTMxZmJFREtoVmZKeEJGSjVpd25ENkxnZmFHb1wvQlkzMjNzanNoSTViczlnOEhIT0g0TGRYUXBBWTQifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/9] app/procinfo: add usage for new debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 15:06:18 -0000 > > @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname) > > " --stats-reset: to reset port statistics\n" > > " --xstats-reset: to reset port extended statistics\n" > > " --collectd-format: to print statistics to STDOUT in expected > by > > collectd format\n" > > - " --host-id STRING: host id used to identify the system process > > is running on\n", > > + " --host-id STRING: host id used to identify the system process > > is running on\n" > > + " --show-port to display ports information\n" > > + " --show-tm to display traffic manager information for > ports\n" > > + " --show-crypto to display crypto information\n" > > + " --show-ring[=3Dname] to display ring information\n" > > + " --show-mempool[=3Dname] to display mempool > information\n" > > + " --iter-mempool=3Dname to iterate mempool elements\n", > > prgname); > > } > > >=20 > Style related comment, add ' :' between command token and token messag= e, > similar to host-id and other . >=20 > Is iter-mempool option, only to iterate only or to display the elements a= lso? > Then update the help message. Thanks for sharing this thought, I am clear with the idea this does not con= vey the complete required message as explained 'Patch 9/9'. Hence I am read= y to reword as "" --iter-mempool=3Dname: to iterate mempool elements and d= isplay content\n " >=20 > Thanks, > Reshma