From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9CEF12C6A for ; Thu, 27 Dec 2018 03:46:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2018 18:46:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,403,1539673200"; d="scan'208";a="110188715" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 26 Dec 2018 18:46:54 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 26 Dec 2018 18:46:54 -0800 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 26 Dec 2018 18:46:54 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX106.gar.corp.intel.com ([169.254.1.128]) with mapi id 14.03.0415.000; Thu, 27 Dec 2018 08:16:53 +0530 From: "Varghese, Vipin" To: Thomas Monjalon CC: "Pattan, Reshma" , "dev@dpdk.org" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Mcnamara, John" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Thread-Index: AQHUkqIChTM8jv1BUUKrANUUQroTMaV8YrgAgAB3rGCADheAAIAFnbKAgAC0NwCAALG6wA== Date: Thu, 27 Dec 2018 02:46:52 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DF4B6@BGSMSX101.gar.corp.intel.com> References: <20181203055000.39012-2-vipin.varghese@intel.com> <1651608.RmD6NkZceM@xps> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DF1A4@BGSMSX101.gar.corp.intel.com> <1797411.vFYqA0X0Ny@xps> In-Reply-To: <1797411.vFYqA0X0Ny@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWY5Njg5ZmEtNTFlNC00Njc1LTg0Y2ItZTliNmNhODBiOTQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGI3cFZFQzlLNnQ1djBQd3lJakx6R0FTS1JCXC9MY1kxOThrNGRldW9zUGRNOFpBQlRqMjltWk1KdnZIejN0c1QifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 02:46:56 -0000 snipped > > > > > Small nits > > > > > 9th patch in this set is doc. So above info need to be corrected. > > > > > if you are addressing my earlier comment of separating out > > > > > mempool element iteration changes in to separate new patch 9/10 > > > > > .Please keep my ack in next version > > > > > > > > Thanks for pointing this out, Like updated in email and chat I am > > > > not > > > planning to split it. Hence no version 8. > > > > > > So, no ack and no merge? > > > > > > Looking at the first patches + doc patch, the split is not meaningful= . > > > You should merge doc and option parsing in the related patches. > > > For instance, parsing and doc of "tm" option should be in the "tm" pa= tch. > > > > I did not follow you request. Are you stating, for each functionality I= should > be updating document rather than 1 document update after adding the new > functions? If former is true I am not able to find such reasoning stated = in > guideline or documentation or from the maintainer. >=20 > Yes, you should update the doc while adding a new feature. Ok, I will comply to your requirement even though it is not in 'guideline, = documentation or from maintainer'. Humbly requesting to update documentatio= n and guideline suggesting the same. This will also help others to submit p= atches according the new guideline. Once reflected it will be justified for= sending a v8. > But most importantly, there is no reason to do a patch adding some empty > functions and filling them later. Following are the reasons for using stub function from v1 onwards till v7 1. Without the dummy function there are compiler warnings for unused variab= les. 2. It is logical to have stub functions for the new parse option being adde= d in one go. These are based on the suggestion from the maintainer. > And please consider the option parsing is part of the feature. As mentioned above please find the reasoning stated for patches from v1 to = v7.