From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 90A071B5BC for ; Thu, 10 Jan 2019 09:53:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 00:53:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,460,1539673200"; d="scan'208";a="105509434" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 10 Jan 2019 00:53:42 -0800 Received: from bgsmsx152.gar.corp.intel.com (10.224.48.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 00:53:42 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.128]) by BGSMSX152.gar.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 14:23:39 +0530 From: "Varghese, Vipin" To: Thomas Monjalon CC: "dev@dpdk.org" , "Pattan, Reshma" , "Mcnamara, John" , "Patel, Amol" , "stephen@networkplumber.org" , "Ananyev, Konstantin" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions Thread-Index: AQHUpm03E0cC0f5CLEyCP8ONBDfNEqWnQaEAgACUxxCAAAB3gIAAXUKQ Date: Thu, 10 Jan 2019 08:53:38 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com> References: <20181213050842.64587-1-vipin.varghese@intel.com> <15168357.XSmGzJBqIm@xps> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE451@BGSMSX101.gar.corp.intel.com> <4383677.neL5jlz7Vu@xps> In-Reply-To: <4383677.neL5jlz7Vu@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2QzMGUyZTQtODlkYi00YjVmLTkxYzAtMjBhZDg0NGE1N2NmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQkVPbUpBTXVBS01jMVdcLzl5OGs2bk1FQ1ltbENwZGpjTzFcL3RTQUwyXC9QNEJNaENxU1hiYlY5dUFtVWJmXC81YnkifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 08:53:44 -0000 Hi Thomas, snipped >=20 > 10/01/2019 04:08, Varghese, Vipin: > > snipped > > > > > > Hi Vipin, > > > > > > The code split in this v8 looks really better, except this patch > > > which makes no sense alone. > > Hi Thomas, I need this base patch as first one. These include the helpe= r > MACRO and include which pans out for next 7 patches. > > > > > I feel you can move these changes in next patches, where appropriate,= isn't > it? > > Patches v2 to v7 uses common features from v1. >=20 > At least, you should introduce the includes when needed. As mentioned earlier these are used in v2 to v7. > If you need this patch for introducing some macros, then rename it and > explain the macros in the message. The MACRO introduced in this patch are 'MAX_STRING_LEN, STATS_BDR_FMT and S= TATS_BDR_STR'. As per code contribution guideline I may have missed out the= stipulation requesting for explaining the same. >=20 >=20 > > > 07/01/2019 16:38, Vipin Varghese: > > > > Update code base and meson build file to accommodate changes for > > > > the new functionality. > > > > > > > > Signed-off-by: Vipin Varghese > > > > Acked-by: Reshma Pattan > > > > --- snipped