From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 530771B90D for ; Thu, 10 Jan 2019 17:38:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 08:38:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,462,1539673200"; d="scan'208";a="126625565" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 10 Jan 2019 08:38:00 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 08:38:00 -0800 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 08:38:00 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.128]) by BGSMSX109.gar.corp.intel.com ([169.254.10.162]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 22:07:57 +0530 From: "Varghese, Vipin" To: Thomas Monjalon , "Kovacevic, Marko" CC: "dev@dpdk.org" , "Richardson, Bruce" , "Mcnamara, John" , "Patel, Amol" , "Byrne, Stephen1" , "honnappa.nagarahalli@arm.com" Thread-Topic: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide Thread-Index: AQHUcFwFmL1w9p+/G0mowOj9mcl0YaVPEDeAgBACCgCAShG34A== Date: Thu, 10 Jan 2019 16:37:56 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EFA35@BGSMSX101.gar.corp.intel.com> References: <20181030141345.23725-1-vipin.varghese@intel.com> <20181030141847.23861-1-vipin.varghese@intel.com> <6DC05C7C5F25994B81B3F2F214251F660205059B@IRSMSX104.ger.corp.intel.com> <2703864.trOpUck9ay@xps> In-Reply-To: <2703864.trOpUck9ay@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjIzYjExMjUtNDA0MC00YTAyLTg1YTEtY2E5MzZmMzk0OTFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicUprSGxHWk5aMkNFbnJxK1JlNEN0UjNjTjZaSURyVys5RTBUQXd6K1lObUdPYUR3VFhFNXNaZzA3TGpsUmllTiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 16:38:02 -0000 HI Thomas snipped > > > > > > +Compliation of patches has to be tested using meson:: > > > + > > > + ./devtools/test-meson-builds.sh > > > + > > > +This will test for shared and static builds. If gcc arm cross > > > +compiler is installed, cross build is tested too. > > > > > > Sending Patches > > > --------------- > > > > Ran the script all runs fine > > > > Tested-by: Marko Kovacevic > > Acked-by: Marko Kovacevic >=20 > Yes we must add such explanation, but it can be improved. >=20 > We should make clear that meson must be tested in addition of make. In Patch ' https://patches.dpdk.org/patch/47562/=B4as per suggestion Bruce,= we have given emphasis on ' Compliation of patches has to be tested using= meson'. In my opinion, this is bare minimum one liner, which is required t= o be executed for any patch before sending. =20 >=20 > We could be more explicit about cross-compilation, saying on x86 host, bo= th > x86 and Arm can be compiled thanks to the cross compilers. >=20 I believe this should be covered about compilation section and features. > More details: > - s/Compliation/Compilation/ > - the double blank line is removed before next header >=20 >=20