From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B7F585B16 for ; Mon, 28 Jan 2019 15:27:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2019 06:27:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,534,1539673200"; d="scan'208";a="129519769" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 28 Jan 2019 06:27:19 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 06:27:19 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.7]) by BGSMSX107.gar.corp.intel.com ([169.254.9.242]) with mapi id 14.03.0415.000; Mon, 28 Jan 2019 19:57:16 +0530 From: "Varghese, Vipin" To: Thomas Monjalon CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Yigit, Ferruh" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide Thread-Index: AQHUtAd6X2c9u7oxlEmh9ClOj3qtxKXDf4QAgAE9xyA= Date: Mon, 28 Jan 2019 14:27:15 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com> References: <20181030141847.23861-1-vipin.varghese@intel.com> <20190124230541.58343-1-vipin.varghese@intel.com> <1830265.56Hsnbp04L@xps> In-Reply-To: <1830265.56Hsnbp04L@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzY2NGRjMjUtZmIzZC00OGM2LThmZWYtYWJhYTBmOTNmYTU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUdpVGZ3QVEwZ3A0U1pMaU1EanZXMEliTklQQWp6UisxVkp3YW1ncGNqOG5NZTZiTnptTlo4VDhcL3BKUk15ajEifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 14:27:21 -0000 Hi Thomas, snipped=20 > > +Compilation of patches is to be tested with ``test-meson-builds.sh`` > > +script in ``devtools`` directory of the DPDK repo:: >=20 > Would be more straight-forward to give the full path: > devtools/test-meson-builds.sh I also like to use ' devtools/test-meson-builds.sh', but based I followed t= he formatting used for 'test-build.sh'.=20 Which is ``` Compilation of patches and changes should be tested using the = test-build.sh script in the devtools directory of the DPDK repo```.=20 > No need to add "DPDK repo". >=20 > > + > > + devtools/test-meson-builds.sh >=20 > Do we really need to repeat the script name here? Same as above.=20 Note: please let me know if you still require the change for above items? >=20 > > + > > +The script internally checks for dependencies and tool chain. Then > > +builds with >=20 > tool chain -> toolchain I will fix this and share the updated version. >=20 > > +shared and static libraries for Linux and BSD targets. >=20 > Why "Linux and BSD" ? It is just testing for the running OS. The default execution generates for default targets as ' build-gcc-shared, = build-gcc-static & build-x86-default'. If cross build is supported ' build-= clang-shared & build-clang-static'. As per my understanding this will true for Linux and BSD (Windows I am not = aware). Hence I mention it as 'Linux and BSD'. Note:=20 1. If it is with regard to wording I can reword from ' Then builds with sha= red and static libraries for Linux and BSD targets' to 'Then binaries are b= uilt with static and shared library for default and arm cross build on Linu= x and BSD' 2.if support & built infrastructure works for Windows I can reword from ' T= hen builds with shared and static libraries for Linux and BSD targets' to '= Then binaries are built with static and shared library for default and arm = cross build for Host OS' Please let me know is 1 or 2 is right one? >=20 >=20