Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide

["Varghese, Vipin" <vipin.varghese@intel.com>]

Thanks Thomas for the updates, I will check and send next version soon

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, January 28, 2019 8:23 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic,
> Marko <marko.kovacevic@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Padubidri, Sanjay A <sanjay.padubidri@intel.com>; Patel, Amol
> <amol.patel@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to
> contributing guide
> 
> 28/01/2019 15:27, Varghese, Vipin:
> > Hi Thomas,
> >
> > snipped
> > > > +Compilation of patches is to be tested with
> > > > +``test-meson-builds.sh`` script in ``devtools`` directory of the DPDK
> repo::
> > >
> > > Would be more straight-forward to give the full path:
> > > 	devtools/test-meson-builds.sh
> > I also like to use ' devtools/test-meson-builds.sh', but based I followed the
> formatting used for 'test-build.sh'.
> >
> > Which is ``` Compilation of patches and changes should be tested using the
> test-build.sh script in the devtools directory of the DPDK repo```.
> >
> > > No need to add "DPDK repo".
> > >
> > > > +
> > > > +   devtools/test-meson-builds.sh
> > >
> > > Do we really need to repeat the script name here?
> > Same as above.
> >
> > Note: please let me know if you still require the change for above items?
> 
> Yes I've seen it was like that for make test.
> Given the meson test script has no argument, it's better to make it simple and
> just give the full path.
> 
> > > > +The script internally checks for dependencies and tool chain.
> > > > +Then builds with
> > >
> > > tool chain -> toolchain
> > I will fix this and share the updated version.
> >
> > > > +shared and static libraries for Linux and BSD targets.
> > >
> > > Why "Linux and BSD" ? It is just testing for the running OS.
> > The default execution generates for default targets as ' build-gcc-shared,
> build-gcc-static & build-x86-default'. If cross build is supported ' build-clang-
> shared & build-clang-static'.
> >
> > As per my understanding this will true for Linux and BSD (Windows I am not
> aware). Hence I mention it as 'Linux and BSD'.
> >
> > Note:
> > 1. If it is with regard to wording I can reword from ' Then builds with shared
> and static libraries for Linux and BSD targets' to 'Then binaries are built with
> static and shared library for default and arm cross build on Linux and BSD'
> > 2.if support & built infrastructure works for Windows I can reword from '
> Then builds with shared and static libraries for Linux and BSD targets' to 'Then
> binaries are built with static and shared library for default and arm cross build
> for Host OS'
> >
> > Please let me know is 1 or 2 is right one?
> 
> We must avoid giving too much details because it will be outdated quickly
> when updating the script. Please keep it simple and don't mention Linux/BSD
> or Arm.
> You can just explain the intent: it is testing several combinations of
> compilation configurations.
> 
>