From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 335586CC1 for ; Mon, 28 Jan 2019 16:40:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2019 07:40:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,534,1539673200"; d="scan'208";a="113306378" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 28 Jan 2019 07:40:24 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 07:40:24 -0800 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 07:40:23 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.7]) by BGSMSX109.gar.corp.intel.com ([169.254.10.162]) with mapi id 14.03.0415.000; Mon, 28 Jan 2019 21:10:20 +0530 From: "Varghese, Vipin" To: Thomas Monjalon CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Yigit, Ferruh" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide Thread-Index: AQHUtAd6X2c9u7oxlEmh9ClOj3qtxKXDf4QAgAE9xyD//7CmAIAAaW8w Date: Mon, 28 Jan 2019 15:40:20 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F7739@BGSMSX101.gar.corp.intel.com> References: <20181030141847.23861-1-vipin.varghese@intel.com> <1830265.56Hsnbp04L@xps> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com> <4064656.Pp56jkNFLl@xps> In-Reply-To: <4064656.Pp56jkNFLl@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzdkYjY4NjQtNmFhYi00NjI5LTg4OTktMmI3MDNkYjBjMmVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWnZiaXdGV3d1bEVLbGlnSFU2WDhpcW5PaGhWMDg1MWNsNHhTdDRyeGRpWHA4VzEzenRibzc2Zk53bFBaZGRxSyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 15:40:26 -0000 Thanks Thomas for the updates, I will check and send next version soon > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, January 28, 2019 8:23 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko ; Yigit, Ferruh = ; > Padubidri, Sanjay A ; Patel, Amol > > Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to > contributing guide >=20 > 28/01/2019 15:27, Varghese, Vipin: > > Hi Thomas, > > > > snipped > > > > +Compilation of patches is to be tested with > > > > +``test-meson-builds.sh`` script in ``devtools`` directory of the D= PDK > repo:: > > > > > > Would be more straight-forward to give the full path: > > > devtools/test-meson-builds.sh > > I also like to use ' devtools/test-meson-builds.sh', but based I follow= ed the > formatting used for 'test-build.sh'. > > > > Which is ``` Compilation of patches and changes should be tested using = the > test-build.sh script in the devtools directory of the DPDK repo```. > > > > > No need to add "DPDK repo". > > > > > > > + > > > > + devtools/test-meson-builds.sh > > > > > > Do we really need to repeat the script name here? > > Same as above. > > > > Note: please let me know if you still require the change for above item= s? >=20 > Yes I've seen it was like that for make test. > Given the meson test script has no argument, it's better to make it simpl= e and > just give the full path. >=20 > > > > +The script internally checks for dependencies and tool chain. > > > > +Then builds with > > > > > > tool chain -> toolchain > > I will fix this and share the updated version. > > > > > > +shared and static libraries for Linux and BSD targets. > > > > > > Why "Linux and BSD" ? It is just testing for the running OS. > > The default execution generates for default targets as ' build-gcc-shar= ed, > build-gcc-static & build-x86-default'. If cross build is supported ' buil= d-clang- > shared & build-clang-static'. > > > > As per my understanding this will true for Linux and BSD (Windows I am = not > aware). Hence I mention it as 'Linux and BSD'. > > > > Note: > > 1. If it is with regard to wording I can reword from ' Then builds with= shared > and static libraries for Linux and BSD targets' to 'Then binaries are bui= lt with > static and shared library for default and arm cross build on Linux and BS= D' > > 2.if support & built infrastructure works for Windows I can reword from= ' > Then builds with shared and static libraries for Linux and BSD targets' t= o 'Then > binaries are built with static and shared library for default and arm cro= ss build > for Host OS' > > > > Please let me know is 1 or 2 is right one? >=20 > We must avoid giving too much details because it will be outdated quickly > when updating the script. Please keep it simple and don't mention Linux/B= SD > or Arm. > You can just explain the intent: it is testing several combinations of > compilation configurations. >=20 >=20