From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B9ADD326D for ; Thu, 28 Mar 2019 03:30:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 19:30:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,278,1549958400"; d="scan'208";a="311015043" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 27 Mar 2019 19:30:20 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 19:30:20 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 19:30:19 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.171]) by BGSMSX102.gar.corp.intel.com ([169.254.2.152]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 08:00:15 +0530 From: "Varghese, Vipin" To: "Rawat, Anand" , "dev@dpdk.org" CC: "Rawat, Anand" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" , "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows Thread-Index: AQHU5Q0cpSoNRI8V9E6sWXDFTiCYxqYgUeqw Date: Thu, 28 Mar 2019 02:30:13 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D326E11@BGSMSX101.gar.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-5-anand.rawat@intel.com> In-Reply-To: <20190328022115.4660-5-anand.rawat@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk3ZmNhYzAtYmU1My00NTVlLWFlZTAtYTkyNzBjNGNkNTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidngyMXZlMDB0cU1FSUs4MDJENW84K3RyZ05SM1BuYUtYZFByTVErcSt5Zk1nN2FyZXVlQWwyWlo5VWVObmcyTSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 02:30:22 -0000 Hi Anand, snipped >=20 > Adding sys/queue.h on windows for supporting common code. > This is implementation has BSD-3-Clause licensing. >=20 > Signed-off-by: Ranjit Menon > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > --- > .../windows/eal/include/sys/queue.h | 320 ++++++++++++++++++ > 1 file changed, 320 insertions(+) > create mode 100644 lib/librte_eal/windows/eal/include/sys/queue.h >=20 > diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h > b/lib/librte_eal/windows/eal/include/sys/queue.h > new file mode 100644 > index 000000000..5ee4916ad > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/sys/queue.h > @@ -0,0 +1,320 @@ > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1991, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in th= e > + * documentation and/or other materials provided with the distributio= n. > + * 3. Neither the name of the University nor the names of its contributo= rs > + * may be used to endorse or promote products derived from this softw= are > + * without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' > AND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, > THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE > LIABLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > CONSEQUENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > SUBSTITUTE GOODS > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > CONTRACT, STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN > ANY WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY > OF > + * SUCH DAMAGE. > + * > + */ Can you help me understand why this should not be=20 ``` # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corporat= ion +# Copyright(c) 2017-2019 Intel Corporation ``` snipped From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00F09A05D3 for ; Thu, 28 Mar 2019 03:30:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 163305F1A; Thu, 28 Mar 2019 03:30:23 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B9ADD326D for ; Thu, 28 Mar 2019 03:30:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 19:30:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,278,1549958400"; d="scan'208";a="311015043" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 27 Mar 2019 19:30:20 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 19:30:20 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Mar 2019 19:30:19 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.171]) by BGSMSX102.gar.corp.intel.com ([169.254.2.152]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 08:00:15 +0530 From: "Varghese, Vipin" To: "Rawat, Anand" , "dev@dpdk.org" CC: "Rawat, Anand" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" , "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows Thread-Index: AQHU5Q0cpSoNRI8V9E6sWXDFTiCYxqYgUeqw Date: Thu, 28 Mar 2019 02:30:13 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D326E11@BGSMSX101.gar.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-5-anand.rawat@intel.com> In-Reply-To: <20190328022115.4660-5-anand.rawat@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk3ZmNhYzAtYmU1My00NTVlLWFlZTAtYTkyNzBjNGNkNTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidngyMXZlMDB0cU1FSUs4MDJENW84K3RyZ05SM1BuYUtYZFByTVErcSt5Zk1nN2FyZXVlQWwyWlo5VWVObmcyTSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328023013.EsrZ12zkf6jSI2cx8yrbGpc2q4VOCvo4FiYSd9x_vVg@z> Hi Anand, snipped >=20 > Adding sys/queue.h on windows for supporting common code. > This is implementation has BSD-3-Clause licensing. >=20 > Signed-off-by: Ranjit Menon > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > --- > .../windows/eal/include/sys/queue.h | 320 ++++++++++++++++++ > 1 file changed, 320 insertions(+) > create mode 100644 lib/librte_eal/windows/eal/include/sys/queue.h >=20 > diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h > b/lib/librte_eal/windows/eal/include/sys/queue.h > new file mode 100644 > index 000000000..5ee4916ad > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/sys/queue.h > @@ -0,0 +1,320 @@ > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1991, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in th= e > + * documentation and/or other materials provided with the distributio= n. > + * 3. Neither the name of the University nor the names of its contributo= rs > + * may be used to endorse or promote products derived from this softw= are > + * without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' > AND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, > THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE > LIABLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > CONSEQUENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > SUBSTITUTE GOODS > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > CONTRACT, STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN > ANY WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY > OF > + * SUCH DAMAGE. > + * > + */ Can you help me understand why this should not be=20 ``` # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corporat= ion +# Copyright(c) 2017-2019 Intel Corporation ``` snipped