From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E5CEF5323 for ; Mon, 8 Apr 2019 05:01:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 20:01:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,323,1549958400"; d="scan'208";a="221431229" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 07 Apr 2019 20:01:51 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 20:01:51 -0700 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 20:01:51 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.171]) by BGSMSX109.gar.corp.intel.com ([169.254.10.43]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 08:31:47 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "Kovacevic, Marko" , "david.marchand@redhat.com" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [PATCH v6 2/2] app/pdump: enhance to support multi-core capture Thread-Index: AQHU6sQcmaho6U3ImU2KYZWyDCD4aaYtcsuAgAQls1A= Date: Mon, 8 Apr 2019 03:01:47 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32ACA8@BGSMSX101.gar.corp.intel.com> References: <20190402091836.35779-3-vipin.varghese@intel.com> <20190404085515.15789-1-vipin.varghese@intel.com> <20190404085515.15789-3-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A443D4B@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A443D4B@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjA2ZjczOGItOGJlNC00ZjQ5LTgzMDQtZDIwODE2NmEzZGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUZaWEQ4MjJOXC9qSlpWZ2MxNDhWTzN1WmFXRlRQOHpBUGdGakRqbTZFc0JpTm11XC9hTGN5cnROZUl0dUszVTFOIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 03:01:53 -0000 Hi Reshma, snipped > Nit picks: >=20 > > > > +The ``--multi`` command line option is optional argument. If passed, > > +capture will be running on unique cores for all ``--pdump`` options. > > +If ignored, capture will be running on single core for all ``--pdump``= options. > > + >=20 > Instead of just saying on single cores or on unique cores, worth mentioni= ng uses > the 1st core of eal coremask/corelist for single case. I have humbly disagree with this point, since the value of 1st core varies = with isol, taskset, and eal option '--master'.=20 > For multi case uses the cores except the 1st in one in coremask? Same as above. >=20 > > The ``--pdump`` command line option is mandatory and it takes various > > sub arguments which are described in below section. >=20 >=20 > > + $ sudo ./build/app/dpdk-pdump -l 3,4,5 -- --multi --pdump > > 'port=3D0,queue=3D*,rx-dev=3D/tmp/rx-1.pcap' --pdump 'port=3D1,queue=3D= *,rx- > > dev=3D/tmp/rx-2.pcap' > > -- > > 2.17.1 >=20 > In the command if you pass anything --m/--mul/--mult/multi the command st= ill > succeeds.. Did you check the reason for that? Yes it passes, during unit test checked too. But I do not understand if it = is problem. >=20 > Thanks, > Reshma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3DBD8A0096 for ; Mon, 8 Apr 2019 05:01:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEFE55323; Mon, 8 Apr 2019 05:01:53 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E5CEF5323 for ; Mon, 8 Apr 2019 05:01:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 20:01:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,323,1549958400"; d="scan'208";a="221431229" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 07 Apr 2019 20:01:51 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 20:01:51 -0700 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 20:01:51 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.171]) by BGSMSX109.gar.corp.intel.com ([169.254.10.43]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 08:31:47 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "Kovacevic, Marko" , "david.marchand@redhat.com" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [PATCH v6 2/2] app/pdump: enhance to support multi-core capture Thread-Index: AQHU6sQcmaho6U3ImU2KYZWyDCD4aaYtcsuAgAQls1A= Date: Mon, 8 Apr 2019 03:01:47 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32ACA8@BGSMSX101.gar.corp.intel.com> References: <20190402091836.35779-3-vipin.varghese@intel.com> <20190404085515.15789-1-vipin.varghese@intel.com> <20190404085515.15789-3-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A443D4B@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A443D4B@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjA2ZjczOGItOGJlNC00ZjQ5LTgzMDQtZDIwODE2NmEzZGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUZaWEQ4MjJOXC9qSlpWZ2MxNDhWTzN1WmFXRlRQOHpBUGdGakRqbTZFc0JpTm11XC9hTGN5cnROZUl0dUszVTFOIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408030147.oj94MjLAKsAP0-rnrw0JI7ZxfoX3hGLxGeXFsRZMhVA@z> Hi Reshma, snipped > Nit picks: >=20 > > > > +The ``--multi`` command line option is optional argument. If passed, > > +capture will be running on unique cores for all ``--pdump`` options. > > +If ignored, capture will be running on single core for all ``--pdump``= options. > > + >=20 > Instead of just saying on single cores or on unique cores, worth mentioni= ng uses > the 1st core of eal coremask/corelist for single case. I have humbly disagree with this point, since the value of 1st core varies = with isol, taskset, and eal option '--master'.=20 > For multi case uses the cores except the 1st in one in coremask? Same as above. >=20 > > The ``--pdump`` command line option is mandatory and it takes various > > sub arguments which are described in below section. >=20 >=20 > > + $ sudo ./build/app/dpdk-pdump -l 3,4,5 -- --multi --pdump > > 'port=3D0,queue=3D*,rx-dev=3D/tmp/rx-1.pcap' --pdump 'port=3D1,queue=3D= *,rx- > > dev=3D/tmp/rx-2.pcap' > > -- > > 2.17.1 >=20 > In the command if you pass anything --m/--mul/--mult/multi the command st= ill > succeeds.. Did you check the reason for that? Yes it passes, during unit test checked too. But I do not understand if it = is problem. >=20 > Thanks, > Reshma