DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Padubidri, Sanjay A" <sanjay.padubidri@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc/testpmd: update compile steps for bpf examples
Date: Thu, 30 May 2019 15:40:46 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D355F7A@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <9691966.DS2kSCyb6N@xps>

HI Thomas,

Snipped

> > +
> > +   To built other BPF examples, the compiler requires additional command-
> line options.
> 
> "To built" -> "To build"
ok

> 
> I think this note is vague. Don't you think it may confuse user if we don't
> explicit which kind of options are required?

Ok, the `v1` content was `In order to build t2.c and t3.c; pass DPDK targets include and library path as compiler options.`. But as user adds other library functions are added to `examples/bpf' these may vary too.

Hence should we state as, `To build other BPF examples, appropriate libraries and dependencies is to be passed as command line options.`




  reply	other threads:[~2019-05-30 15:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  8:41 [dpdk-dev] [PATCH] " Vipin Varghese
2019-05-07  8:41 ` Vipin Varghese
2019-05-07 15:07 ` Mcnamara, John
2019-05-07 15:07   ` Mcnamara, John
2019-05-09 22:31 ` Thomas Monjalon
2019-05-09 22:31   ` Thomas Monjalon
2019-05-10  1:41   ` Varghese, Vipin
2019-05-10  1:41     ` Varghese, Vipin
2019-05-23 13:47 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2019-05-29 11:17   ` Thomas Monjalon
2019-05-30 15:40     ` Varghese, Vipin [this message]
2019-06-10  5:41   ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2023-06-12 16:31     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D355F7A@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=sanjay.padubidri@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).