From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D507BA3201 for ; Mon, 21 Oct 2019 05:12:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30865F3E; Mon, 21 Oct 2019 05:12:22 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E8DF9A69 for ; Mon, 21 Oct 2019 05:12:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 20:12:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,322,1566889200"; d="scan'208";a="280841387" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 20 Oct 2019 20:12:19 -0700 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 20:12:19 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.199]) by BGSMSX109.gar.corp.intel.com ([169.254.10.209]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 08:42:16 +0530 From: "Varghese, Vipin" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Kovacevic, Marko" , Ori Kam , "Nicolau, Radu" , Akhil Goyal , "Kantecki, Tomasz" , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown Thread-Index: AQHVgrynGoRuD5GrqUiKl0IPOofGY6dkc1zg Date: Mon, 21 Oct 2019 03:12:15 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DCA46@BGSMSX101.gar.corp.intel.com> References: <20191002205754.11746-1-pbhagavatula@marvell.com> <20191014182247.961-1-pbhagavatula@marvell.com> <20191014182247.961-10-pbhagavatula@marvell.com> In-Reply-To: <20191014182247.961-10-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjM1ZTU3ZmMtOTI4YS00OGJlLWExMzgtNmJjYTg5MWFmMWM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT21ya1F3dFRLVG02VDBQczZET0lpK2o2aURnYjdlWXhRRFQ2TktsenNzbXFkNWN2bmJCNUd6ZGZxb2dvXC85VnYifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, snipped >=20 > Add graceful teardown that addresses both event mode and poll mode. >=20 > Signed-off-by: Pavan Nikhilesh > --- snipped > + if (rsrc->event_mode) { > + struct l2fwd_event_resources *evt_rsrc =3D > + rsrc->evt_rsrc; > + for (i =3D 0; i < evt_rsrc->rx_adptr.nb_rx_adptr; i++) > + rte_event_eth_rx_adapter_stop( > + evt_rsrc->rx_adptr.rx_adptr[i]); Question from my end, for a graceful tear down first we stop the RX adapter= then ensure after all events from worker are either dropped or transmit. T= hen we continue to TX adapter is stop. Is this right way? > + for (i =3D 0; i < evt_rsrc->tx_adptr.nb_tx_adptr; i++) > + rte_event_eth_tx_adapter_stop( > + evt_rsrc->tx_adptr.tx_adptr[i]); Should we call `rte_cleanup` to clean up the service core usage? > } > printf("Bye...\n"); >=20 > -- > 2.17.1