From: "Damjan Marion (damarion)" <damarion@cisco.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] 16.07-rc2 issue with rte_rtm_init(void) constructor
Date: Thu, 14 Jul 2016 13:24:32 +0000 [thread overview]
Message-ID: <4D14F238-BFBE-43E6-B85C-59048692C8E2@cisco.com> (raw)
In-Reply-To: <8960687.gEONPgFZ8H@xps13>
> On 14 Jul 2016, at 13:30, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> 2016-07-14 09:36, Damjan Marion:
>>>>
>>>> linking fails with:
>>>> dpdk/include/rte_spinlock.h:103: undefined reference to `rte_cpu_get_flag_enabled’
>>>>
>>>> Is there any chance that this one is moved to some .c file, so it is loaded
>>>> only when it is really needed?
>>>
>>> Yes it could be moved to lib/librte_eal/common/arch/x86/.
>>
>> Any chance to get this in 16.07 ?
>
> Yes maybe if you submit a patch quickly and it is clean enough.
OK, I already have working patch[1], but it is possibly not clean enough.
Basically I moved rte_rtm_init to lib/librte_eal/common/arch/x86/rte_cpuflags.c
Is this the right place?
Should we call “rtm_supported” different, knowing that now it is not static anymore?
Thanks,
Damjan
[1] https://github.com/vpp-dev/vpp/blob/dpdk-16.07-rc2/dpdk/dpdk-16.07-rc2_patches/0001-Fix-linking-issue-due-to-constructor-in-header-file.patch
prev parent reply other threads:[~2016-07-14 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 22:58 Damjan Marion (damarion)
2016-07-14 8:20 ` Thomas Monjalon
2016-07-14 9:36 ` Damjan Marion (damarion)
2016-07-14 11:30 ` Thomas Monjalon
2016-07-14 13:24 ` Damjan Marion (damarion) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D14F238-BFBE-43E6-B85C-59048692C8E2@cisco.com \
--to=damarion@cisco.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).