From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aaron@arbor.net>
Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com
 [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 4C4987F30
 for <dev@dpdk.org>; Wed,  5 Nov 2014 16:24:42 +0100 (CET)
Received: by mail-ie0-f173.google.com with SMTP id tr6so915240ieb.32
 for <dev@dpdk.org>; Wed, 05 Nov 2014 07:34:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0;
 h=subject:mime-version:content-type:from:in-reply-to:date:cc
 :message-id:references:to;
 bh=0VGRYh6EGq1cW6Xm3GU85FC1mA+mLY28qItVyQXtcDc=;
 b=SZ1UByWajJ4UeS4QbbMiZhBnz0168HRpaRn/JWqhGnB08xrlu9H/qx376nJpBI2VFo
 jxnyOOqvWsODB2VsWApgJEgfw7rfnHtv0rJLKpn9/47YinHI0kdgZlCNTw7GPuADWfDS
 +JZONrYqT84xTKu8F1t5LACJpNv70ICyiAuCU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:mime-version:content-type:from
 :in-reply-to:date:cc:message-id:references:to;
 bh=0VGRYh6EGq1cW6Xm3GU85FC1mA+mLY28qItVyQXtcDc=;
 b=QljGLgr0H4z4pxsyqN0adSedgVDg2ZCbIm4D+YP+Lm2SfGovOEaBwLG6U7nDQDg9SA
 S+3v9FrcfAEIqyG+yGe6b+oe8puQka+qUnHbPcyaTiBodQafdUPhxB2YegOGzovlz8Dw
 y9P9/Ewf9kdULnwGF5IQsU8NBo8KUmH1L8NswboiaVEaN0msrmmMyTxAtHJ775OONeWS
 hAM97rPp5tQgEgFOzFD5OeQU//9p/8LVtvkpdfFAMM7nrqhfqArkSIKs1lpxaev53gNt
 V/eDZglAxHeWNyl+W5d23Mg4jI3SZqSpEuFNRlUaPLyyFmje1PqcrSDIO3uL0ED7t6e4
 AebQ==
X-Gm-Message-State: ALoCoQnQAeuUPGOOV/Y9vPalomLusz6KXCTAFu9WxEFiktgiu0LVLy38/7E7NVVgqD+jeART1AMs
X-Received: by 10.42.142.201 with SMTP id t9mr5325483icu.60.1415201645158;
 Wed, 05 Nov 2014 07:34:05 -0800 (PST)
Received: from [172.31.1.110]
 (hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net.
 [47.55.100.128])
 by mx.google.com with ESMTPSA id 199sm1633229ion.7.2014.11.05.07.34.04
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 05 Nov 2014 07:34:04 -0800 (PST)
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
From: Aaron Campbell <aaron@arbor.net>
In-Reply-To: <1415137233-6364-1-git-send-email-thomas.monjalon@6wind.com>
Date: Wed, 5 Nov 2014 11:34:04 -0400
Message-Id: <4D14FC89-30D5-4DAC-9F34-731C341070F6@arbor.net>
References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>
 <1415137233-6364-1-git-send-email-thomas.monjalon@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
X-Mailer: Apple Mail (2.1990.1)
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal: add option --master-lcore
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2014 15:24:42 -0000

Acked-by: Aaron Campbell <aaron@arbor.net <mailto:aaron@arbor.net>>

Minor comments inline below, I don=E2=80=99t need to see another patch.

Thanks,
-Aaron

> On Nov 4, 2014, at 5:40 PM, Thomas Monjalon =
<thomas.monjalon@6wind.com> wrote:
>=20
> +			RTE_LOG(ERR, EAL, "please specify the master =
lcore id"
> +				"after specifying the coremask\n=E2=80=9D)=
;

Missing a space between =E2=80=9Cid=E2=80=9D and =E2=80=9Cafter=E2=80=9D.

> +			RTE_LOG(ERR, EAL, "please specify the master =
lcore id"
> +				"after specifying the coremask\n=E2=80=9D)=
;

Same here in the Linux version of the code.=