From: Yong Wang <yongwang@vmware.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
John Guzik <john@shieldxnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor
Date: Thu, 7 Apr 2016 18:22:48 +0000 [thread overview]
Message-ID: <4EB925DF-2770-47A8-8331-42BCEA89E790@vmware.com> (raw)
In-Reply-To: <5660045.mydYX4O3xK@xps13>
On 4/7/16, 10:34 AM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>2016-04-07 17:11, John Guzik:
>> With the new jumbo frame patch a latent bug has appeared to have been uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is true, not the first rx descriptor, when rcd->sop is true and rcd->eop could be false.
>> Most likely the reason this has not been seen before is that for non-jumbo frames rcd->eop has always been true when rcd->sop is true as well.
>
>Thanks for reporting.
>Please Yong, could you confirm?
>
>John, 2 tags are needed to be applied:
>Fixes: commit-origin-of-the-bug
>Signed-off-by:
>Please check https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_dev-23send&d=BQICAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=44mSO5N5yEs4CeCdtQE0xt0F7J0p67_mApYVAzyYms0&m=qucd32eb66O4TLIXrrV-znC7i8UqlSsNVl12u64zFxI&s=P5mdk_qNVscagTjvA2DK44y4vfbI0yN2M8XDlBirX5M&e= for more details. Thanks
Please add the sign-off and fixes info as Thomas suggested.
Acked-by: Yong Wang <yongwang@vmware.com>
next prev parent reply other threads:[~2016-04-07 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:11 John Guzik
2016-04-07 17:34 ` Thomas Monjalon
2016-04-07 18:22 ` Yong Wang [this message]
2016-04-07 17:35 ` Stephen Hemminger
2016-04-12 23:08 ` [dpdk-dev] [PATCH] vmxnet3: VLAN tag on end packet, not first John Guzik
2016-05-10 15:04 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB925DF-2770-47A8-8331-42BCEA89E790@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=john@shieldxnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).