From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9BC3C108D for ; Fri, 31 Mar 2017 16:10:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490969434; x=1522505434; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=D0zHkRxdaYUnWl52CKE1OP9I4sNlX21faS4Ib2xQHoY=; b=nTtXENgpGZjRIFJatkewXqkLuhyBcOGX+6fwBrL6SxU0LwD8LR1koFCj Xb6+Tepvt5H6vEMuPddVl9882CGq8g==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 07:10:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="81388064" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2017 07:10:32 -0700 To: Nirmoy Das , dev@dpdk.org References: <20170331113240.2399-1-ndas@suse.de> From: Ferruh Yigit Message-ID: <4a0093ff-6ef4-702d-897a-ac3611d932da@intel.com> Date: Fri, 31 Mar 2017 15:10:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170331113240.2399-1-ndas@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 14:10:35 -0000 On 3/31/2017 12:32 PM, Nirmoy Das wrote: > Add support for SLES12SP3, which uses kernel 4.4, > but backported features from newer kernels. > > Signed-off-by: Nirmoy Das > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > index 84826b26e..3d22d8e69 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > @@ -3929,8 +3929,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > #define vlan_tx_tag_present skb_vlan_tag_present > #endif > > -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) > +#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \ > + || (defined(CONFIG_SUSE_KERNEL) && \ > + (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57)))) > #define HAVE_VF_VLAN_PROTO > -#endif /* >= 4.9.0 */ > +#endif /* >= 4.9.0, >= SLES12SP3 */ To make condition simple, what about separating SUSE related check? There is already "#ifdef CONFIG_SUSE_KERNEL" check in line 699, which is mainly to set SLE_VERSION_CODE, but this check can be added end of that block, what do you think? Thanks, ferruh > > #endif /* _KCOMPAT_H_ */ >