From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release
Date: Wed, 29 Mar 2017 17:25:07 +0100 [thread overview]
Message-ID: <4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com> (raw)
In-Reply-To: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com>
On 3/29/2017 4:08 PM, Andrew Rybchenko wrote:
> Datapath TxQ handle is passed to release function, not control path.
>
> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Please, squash the patch into 5808dbaf751f.
Hi Andrew,
To clarify, for the commits in next-net tree that are not merged yet, we
can benefit from sub-tree re-writable option and squash some fixes,
-without over using it.
But for this patch, as far as I can see, original code added with
commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues")
which is part of v17.02 release.
So, please send a patch with correct fixes line and it won't be squashed.
Thanks,
ferruh
next prev parent reply other threads:[~2017-03-29 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:08 Andrew Rybchenko
2017-03-29 16:25 ` Ferruh Yigit [this message]
2017-03-29 16:37 ` Andrew Rybchenko
2017-03-29 16:59 ` Ferruh Yigit
2017-03-29 16:53 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2017-03-31 12:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).