From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 7E71BF966
 for <dev@dpdk.org>; Wed, 29 Mar 2017 18:25:09 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 29 Mar 2017 09:25:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,242,1486454400"; d="scan'208";a="82349525"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2017 09:25:07 -0700
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
References: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com>
Date: Wed, 29 Mar 2017 17:25:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2017 16:25:09 -0000

On 3/29/2017 4:08 PM, Andrew Rybchenko wrote:
> Datapath TxQ handle is passed to release function, not control path.
> 
> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Please, squash the patch into 5808dbaf751f.

Hi Andrew,

To clarify, for the commits in next-net tree that are not merged yet, we
can benefit from sub-tree re-writable option and squash some fixes,
-without over using it.

But for this patch, as far as I can see, original code added with
commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues")
which is part of v17.02 release.

So, please send a patch with correct fixes line and it won't be squashed.

Thanks,
ferruh