From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id A7C401B3C6 for ; Mon, 5 Feb 2018 15:53:15 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id w50so29898883wrc.2 for ; Mon, 05 Feb 2018 06:53:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=2KFAV09lJr03+DUYdzCrdztJTuA7SmXjBhpW+d/G+TI=; b=FY9YXJOd6IB0iOtEpd0hxLyzezgQvKkuVQ4aQ3gJKm00ygL/wacJ4b/lsU+DCSJn7/ /Uzkf4usPmFK56P6LJ6Oq6dS+885+Ix1IKxGx91pkanEWChtjJ60aSyP93C/mLUFfiT5 xmxZAp1KfHFFsssXe9lXdBJEQdMS8pndlNbfsyJ0ucB9Y6nt4CLDZLnsYQo5YuKaDPXa gI5fPRt9DsU6qnnvdQWHsf193rkfBGP4DdpZfgrDEHMjQweaCb2haGQ3/QB3V6qAW4An +HUvDJ/FDZanykEcf+rDSz3/ic3QEzNQId0CqjKEZDr17QbPhZDL1YGg1jrwVHvhlyZC mudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2KFAV09lJr03+DUYdzCrdztJTuA7SmXjBhpW+d/G+TI=; b=Y1RGvype29nKX5Zd2zkR2LRZUaOgdngJo3MzhRW68mRSL4bPvFqHv6nRSa2iRXsX1X H1dGFRzSq8yTHfXQhT/BNiTiHByImlZVXTsLrjTIpPWLEjOY7uvw4j0K6aGawumuo+8v C8c86qFJxnDT0HtT5pAvH3RBmVtBcrYL/7iRWs+RjP2zgsyz+Dm2jOY2zgQB6+YaYm9Z PFvEzDP9ueh/n1RdBtA6W+opgf82348zOgjYrCCiH1x7PnPwFfJiWNt9l/KbRXtEVAHu 7YTgZBF7ZtnFytnTTqOp+7Qi98bXP7qgv1V5WbXvmsqa/Jd6vNwPF+lNL1vAdz4R6ZLZ dnRg== X-Gm-Message-State: AKwxytfzdPaweZx9T3Tn2RUbPFsUIYxpShZUsVcnpDoVht9VTIu74vmk lwbEVbMgNP6Yg776rZ6J9dZptw== X-Google-Smtp-Source: AH8x225ezLylYW9VOd8wbhZGZ8mtXirx52Vb30I0fymQpjY1heoR5/rMepg8HHh5MnePcdtceL3EXQ== X-Received: by 10.223.149.153 with SMTP id p25mr31841924wrp.155.1517842395387; Mon, 05 Feb 2018 06:53:15 -0800 (PST) Received: from [192.168.1.58] (82.107.69.91.rev.sfr.net. [91.69.107.82]) by smtp.gmail.com with ESMTPSA id z1sm3083479wre.25.2018.02.05.06.53.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 06:53:14 -0800 (PST) To: Ophir Munk , dev@dpdk.org Cc: Thomas Monjalon , Olga Shern , stable@dpdk.org References: <1517828348-488-1-git-send-email-ophirmu@mellanox.com> From: Pascal Mazon Message-ID: <4a6a25e0-ee22-97f9-95bd-8feecd0ee9d2@6wind.com> Date: Mon, 5 Feb 2018 15:53:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517828348-488-1-git-send-email-ophirmu@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 14:53:15 -0000 Acked-by: Pascal Mazon On 05/02/2018 11:59, Ophir Munk wrote: > TAP device is supporting multi segments Tx, however this capability is > not reported when querying the TAP device. > This commit adds this capability report. > > Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk > --- > drivers/net/tap/rte_eth_tap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index dc3847e..ac43db4 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -390,7 +390,8 @@ tap_tx_offload_get_port_capa(void) > * In order to support legacy apps, > * report capabilities also as port capabilities. > */ > - return DEV_TX_OFFLOAD_IPV4_CKSUM | > + return DEV_TX_OFFLOAD_MULTI_SEGS | > + DEV_TX_OFFLOAD_IPV4_CKSUM | > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM; > } > @@ -398,7 +399,8 @@ tap_tx_offload_get_port_capa(void) > static uint64_t > tap_tx_offload_get_queue_capa(void) > { > - return DEV_TX_OFFLOAD_IPV4_CKSUM | > + return DEV_TX_OFFLOAD_MULTI_SEGS | > + DEV_TX_OFFLOAD_IPV4_CKSUM | > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM; > }