From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by dpdk.org (Postfix) with ESMTP id C934B20F for ; Wed, 21 Jun 2017 10:36:20 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ORW002MG2KJGA50@mailout3.w1.samsung.com> for dev@dpdk.org; Wed, 21 Jun 2017 09:36:19 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170621083618eucas1p1ff7ca88894b5057b8c5eb1b2ca909438~KFiYVr0Ef2789027890eucas1p1K; Wed, 21 Jun 2017 08:36:18 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id E3.4D.04459.2003A495; Wed, 21 Jun 2017 09:36:18 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170621083618eucas1p177df652b9f54eaded6ef0c84806b3176~KFiXprHMj1290612906eucas1p1p; Wed, 21 Jun 2017 08:36:18 +0000 (GMT) X-AuditID: cbfec7f1-f796e6d00000116b-f4-594a30023474 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 3D.92.17452.2003A495; Wed, 21 Jun 2017 09:36:18 +0100 (BST) Received: from [106.109.129.180] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ORW00FB82KGQWB0@eusync2.samsung.com>; Wed, 21 Jun 2017 09:36:18 +0100 (BST) To: Sergio Gonzalez Monroy , Hemant Agrawal , Jerin Jacob Cc: Thomas Monjalon , dev@dpdk.org, Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei From: Ilya Maximets Message-id: <4a83011c-4b8c-60af-23bd-c6743299e254@samsung.com> Date: Wed, 21 Jun 2017 11:36:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <9b8eb542-ab5c-f37a-afc8-db65061d35f5@intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyyUcRzH+z7Pc3ePW097HPGZEm7ZrBUS2zOJ2rSeaK1mNtdauXiG/OwO pf7RmJ/hUNJVGyFCK8KxWRPGoZEfya+ZMStaV7jCMYt7zua/13uf9+f7+bw/+5K4pFNgQ0bE xHOKGHmUVCgmmrrWB05grn4y1/5FR2as2oepykgnGN2yBmOKViZFzJu5OiEzkr4uYvIL3Jns 53ohM5HSI2SqVJ2IWZ7REkxqeQvG/JtZxc9S7GDeFGLfa/MErKGkQsCObU0I2bLWBYztGi8S sXW6ZozNbahG7MhqDbpidk3sFcpFRSRyChfvYHG4em5UGDfgdO/jy0mUjGocspAZCbQ7ZBX9 JXi2gi/T74RZSExK6AoEMzkGghcrCLRr2YLdDvWTIQFfeI3gYeoQzosfCP5oFvAdlwXtBaXP fqIdtqSLEajKvHdMOD2MQVaH3viUkD4OvTWdRhNFe8Pbxn4jE7Qj6FuKjHyQDoJvLxpMHnNY K5w2LmtGn4HxqRQj47QrFD/uwHi2gw+1v4wbAb0kgtr0tm1BbgtbqG/D+Qi+sJGpM8WxgMXu BhHPhyEz4xPG96YgSK4eQrxQIdCnVGK8ywd6x7+aph2AgqanpgEUZKRJeAsLOYVzpqueg9wy PoyEbsChQHVZhezUe/Ko92RQ78lQgvBqZMklKKPDOKWbs1IerUyICXMOiY2uR9t/q2+re6kZ /dZ6tiOaRNL91D6HizKJQJ6oTIpuR0DiUksqwMlPJqFC5Un3OUXsTUVCFKdsR4dIQmpNiXtH gyR0mDyei+S4OE6xW8VIM5tk5KgRnO+h6i36vvs7WSXMt/pXoE3Z5CVto4chYOOV5eT1Jlmw QepZm27dOXDjwQieG+suGNSvZF/QJKVFaW6d4m5PpNof1R5ZyM6/WxkYKVFtnvYo9P2sGLRV 15b2JbaF2t8ZbZw1t24i7CidW8ijMtK3nGgcdqGLrwbOuobPSwlluPzkMVyhlP8H1N5rDFcD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t/xK7pMBl6RBgv/sVncWGVvsaKjncXi 3aftTBbTPt9mt1j5eCObxZX2n+wWEyeZWHTP/sJmcav5JJvFiglHGC0+PTjBYtGyZCeTxbcH 35kdeD0u9t9h9Nhwop/V49eCpaweN/7dYvNYvOclk8exm9PYPTa+28Hk0bdlFaPHle+rGQM4 o9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAe rKRvl+CWMevxNbaC8xoV++beZmxgXK3YxcjJISFgIjFr6iVWCFtM4sK99WxdjFwcQgJLGCX+ LZjBCOG8YJQ4PrGbBaRKWMBGYuHM12AJEYEZjBL3G19DVW1hlrj6ZS1YP7PAVSaJJ2dbGEFa 2AR0JE6tPgJm8wrYSazdeg7MZhFQlfiycxqYLSoQIfGwcxc7RI2gxI/J98DWcQrYSty80wxk cwAN1ZO4f1ELJMwsIC+xec1b5gmMArOQdMxCqJqFpGoBI/MqRpHU0uLc9NxiQ73ixNzi0rx0 veT83E2MwAjeduzn5h2MlzYGH2IU4GBU4uFlUPSMFGJNLCuuzD3EKMHBrCTCG6zhFSnEm5JY WZValB9fVJqTWnyI0RTohYnMUqLJ+cDkklcSb2hiaG5paGRsYWFuZKQkzlvy4Uq4kEB6Yklq dmpqQWoRTB8TB6dUA6Pg4q1BJga//+fJmWbNP+XW+PNsTlJcxfu0OfyvFgRsKPU/8bJlUdft guaDakd1+V+mXXz6rmg7787Nb/fN2Wb00Nh6WVnyDN37kjMtuHecNAi5ZhLwYWHr++fOz7r8 Jm1fy1nqtrNU+xeDnFu50teJ2utr+QxEXsnxqJ6texbAstsy6t9so5NKLMUZiYZazEXFiQCc ZnUz9gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170621083618eucas1p177df652b9f54eaded6ef0c84806b3176 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtMZWFkaW5nIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZGluZyBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170621082534epcas2p47c6aaea5b3c49194c8c8f8cdff4e08aa X-RootMTR: 20170621082534epcas2p47c6aaea5b3c49194c8c8f8cdff4e08aa References: <1496736832-835-1-git-send-email-i.maximets@samsung.com> <2889333.ySLvsRWIRF@xps> <3955508.CKAFNdPa9c@xps> <7e71f1d8-f975-05ed-c14c-526c1c2c651f@intel.com> <20170620154138.GA8453@jerin> <40e6b510-72cc-5459-6861-75b6837e3392@nxp.com> <9b8eb542-ab5c-f37a-afc8-db65061d35f5@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 08:36:21 -0000 On 21.06.2017 11:25, Sergio Gonzalez Monroy wrote: > On 21/06/2017 09:14, Hemant Agrawal wrote: >> On 6/20/2017 9:11 PM, Jerin Jacob wrote: >>> -----Original Message----- >>>> Date: Tue, 20 Jun 2017 15:58:50 +0100 >>>> From: Sergio Gonzalez Monroy >>>> To: Thomas Monjalon , Ilya Maximets >>>> >>>> CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson >>>> , David Marchand , >>>> Heetae Ahn , Yuanhan Liu , >>>> Jianfeng Tan , Neil Horman >>>> , Yulong Pei >>>> Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages >>>> User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 >>>> Thunderbird/45.1.1 >>>> >>>> On 20/06/2017 15:35, Thomas Monjalon wrote: >>>>> 20/06/2017 15:58, Ilya Maximets: >>>>>> On 20.06.2017 16:07, Thomas Monjalon wrote: >>>>>>> 19/06/2017 13:10, Hemant Agrawal: >>>>>>>>>>> On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: >>>>>>>>>>>> So, there are 2 option: >>>>>>>>>>>> >>>>>>>>>>>> 1. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>>>>>>>>>> from the first version of the patch and disable it by default. >>>>>>>>>>>> >>>>>>>>>>>> 2. Keep patch as it is now and make everyone install libnuma >>>>>>>>>>>> for successful build. >>>>>>>> +1 for option 1 >>>>>>>> It will be a issue and undesired dependency for SoCs, not supporting >>>>>>>> NUMA architecture. >>>>>>>> >>>>>>>> It can be added to the config, who desired to use it by default. >>>>>>> Yes I agree, it cannot be a dependency for architectures which >>>>>>> do not support NUMA. >>>>>>> Please can we rework the patch so that only one node is assumed >>>>>>> if NUMA is disabled for the architecture? >>>> >>>> Ilya, I missed that libnuma is not supported on ARM. >>> >>> It is supported on arm64 and arm64 has NUMA machines(thunderx, thunderx2) too. >>> >>> [dpdk.org] $ dpkg-query -L libnuma-dev >>> /. >>> /usr >>> /usr/lib >>> /usr/lib/aarch64-linux-gnu >>> /usr/lib/aarch64-linux-gnu/libnuma.a >>> /usr/share >>> /usr/share/man >>> /usr/share/man/man3 >>> /usr/share/man/man3/numa.3.gz >>> /usr/share/doc >>> /usr/share/doc/libnuma-dev >>> /usr/share/doc/libnuma-dev/copyright >>> /usr/include >>> /usr/include/numaif.h >>> /usr/include/numa.h >>> /usr/include/numacompat1.h >>> /usr/lib/aarch64-linux-gnu/libnuma.so >>> >> >> 1. There are many machines (arm/ppc), which do not support NUMA. >> >> https://wiki.linaro.org/LEG/Engineering/Kernel/NUMA >> > > I did find that link too, last modified 4 years ago. > Despite that, I could not find any ARM references in libnuma sources, but Jerin proved that there is support for it. > > http://oss.sgi.com/projects/libnuma/ > https://github.com/numactl/numactl > >> 2. I could not locate it by default in Linaro toolchains. >> >> 3. Since this is not a common across all platform. This option should not be added to the common_base or common configs. It can be added to any architecture configuration, which needs it. >> > > So is it thunderx the only arm64 to enable this feature by default? > I thought the dependency was the libnuma library support itself. ARMv7 is the only architecture without libnuma package in common distros. So, in v6 I enabled this feature by default for x86, ppc and thunderx. I didn't enable it for the whole ARMv8 just because thunderx is the only platform which supports NUMA and has special defconfig in DPDK repository. Best regards, Ilya Maximets. >>>> >>>>>> We're still don't have dynamic build time configuration system. >>>>>> To make get/set_mempolicy work we need to include >>>>>> and have libnuma for successful linkage. >>>>>> This means that the only option to not have libnuma as dependency >>>>>> is to return back configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>>>> as it was in the first version of the patch. >>>>>> >>>>>> There is, actually, the third option (besides 2 already described): >>>>>> >>>>>> 3. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>>>> from the first version of the patch and *enable* it by default. >>>>>> In this case anyone who doesn't want to have libnuma as dependency >>>>>> will be able to disable the config option manually. >>>>>> >>>>>> Thomas, what do you think? Bruce? Sergio? >>>>> It should be enabled on x86 and ppc, and disabled in other >>>>> default configurations (ARM for now). >>>> >>>> Agree. >>>> >>>>>> P.S. We're always able to implement syscall wrappers by hands without any >>>>>> external dependencies, but I don't think it's a good decision. >>>>> I agree to use libnuma instead of re-inventing the wheel. >>>>> Let's just make it optional at build time and fallback on one node >>>>> if disabled. >>>> >>>> That is the simple way out. >>>> >>>> Sergio >>> >> >> > > > >