From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E63DA41DF5; Mon, 6 Mar 2023 15:21:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5A3740EF0; Mon, 6 Mar 2023 15:21:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A06540E50 for ; Mon, 6 Mar 2023 15:21:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678112496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ftr9uvri0y0kg68LKbWidZWsCYaN+9xGODqCvrl3Hbc=; b=Q3Sh68bOUbyn+rUxnC3+zGu1UXZEJWA6sXCjDKPjxNUdJVN55X3oM1LhJVSnCPSkBeEb1s Caru+PGSYfuthorRjnYcNkj0tEPpiGHTXCQ2svJxihcinJ1p2GMBa7xaZGzprfEywJzEJU TJAuV0XENbjHKidCqF1anI90Y5/47hE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-vlcMFmwVMNekzHo3uB1p2w-1; Mon, 06 Mar 2023 09:21:28 -0500 X-MC-Unique: vlcMFmwVMNekzHo3uB1p2w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 181272A5957E; Mon, 6 Mar 2023 14:21:28 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9109492C14; Mon, 6 Mar 2023 14:21:26 +0000 (UTC) Message-ID: <4a9339f3-59db-c339-2722-c63648eea44a@redhat.com> Date: Mon, 6 Mar 2023 15:21:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] vhost: fix vring enable with VDPA To: David Marchand , dev@dpdk.org Cc: ssimma@nvidia.com, yajunw@nvidia.com, Chenbo Xia , =?UTF-8?Q?Morten_Br=c3=b8rup?= References: <20230302094808.1519310-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20230302094808.1519310-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/23 10:48, David Marchand wrote: > For VDPA devices, vq are not locked once the device has been configured. > But we need to hold the vq lock to check if vhost async is enabled. > > Combining VDPA and vhost async does not seem to make much sense, so > prevent this combination, and only assert the lock is taken when VDPA is > not configured on this vq. > > Bugzilla ID: 1169 > Fixes: 4b02c2673757 ("vhost: annotate async accesses") > > Signed-off-by: David Marchand > --- > lib/vhost/vhost.c | 4 ++-- > lib/vhost/vhost_user.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime