From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AB64A0547; Fri, 9 Apr 2021 16:47:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCB97141065; Fri, 9 Apr 2021 16:47:30 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D5E464014D for ; Fri, 9 Apr 2021 16:47:28 +0200 (CEST) IronPort-SDR: C/4YTFr9ZzvK4JirhHgsCngYwaOelXUz+atAGSF73JcAhRbJYsaStf+wUoSjJ+rPLyhtZ06hoz 6obmr/tmBfMg== X-IronPort-AV: E=McAfee;i="6000,8403,9949"; a="193889917" X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="193889917" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 07:47:27 -0700 IronPort-SDR: Vs+p3YHB8dYtNjjxsFNEyzXOHLFPRU+H2b5LXud2zuz0IXSMGQpMZWm+sZRBjxhoNwdrDhfQdH r1ulbT399UVw== X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="422756488" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.45]) ([10.213.203.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 07:47:26 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210406093048.2923172-1-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <4aa70553-97bd-94a0-883f-5c1ce99e7ea8@intel.com> Date: Fri, 9 Apr 2021 15:47:22 +0100 MIME-Version: 1.0 In-Reply-To: <20210406093048.2923172-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/6/2021 10:30 AM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. > > v4: > - Fix compile error. > > v3: > - Use rte_ether functions to define marcos. > > v2: > - Correct some clerical errors. > - Use ethdev debug flags instead of driver own. > > Jiawen Wu (6): > net/ngbe: add build and doc infrastructure > net/ngbe: add device IDs > net/ngbe: support probe and remove > net/ngbe: add device init and uninit > net/ngbe: add log type and error type > net/ngbe: define registers > Hi Jiawen, I put some comments on some patches, but as far as I can see the device is not functional yet after this set, I assume rest of the support will be submitted later. But I think the device should have at least bare minimum functionality when it is upstreamed, like proper device initialization and primitive Rx/Tx, also it would be good to have basic control functions. More control and datapath functionality can be added gradually later. What do you think extending this set to have base minimum functionality? Thanks, ferruh