From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 297BDA0C41; Thu, 16 Sep 2021 05:57:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA7E14003F; Thu, 16 Sep 2021 05:57:51 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 1A9294003C for ; Thu, 16 Sep 2021 05:57:50 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4H93DZ30WGz1DGNy; Thu, 16 Sep 2021 11:56:46 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 11:57:47 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 11:57:47 +0800 To: Thomas Monjalon , CC: , , , , , , , , , , , , , , , References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210907125649.49794-1-fengchengwen@huawei.com> <20210907125649.49794-2-fengchengwen@huawei.com> <1855788.BnNMhiXu0z@thomas> From: fengchengwen Message-ID: <4aa9064f-8305-1fac-c865-9ad269d01b57@huawei.com> Date: Thu, 16 Sep 2021 11:57:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1855788.BnNMhiXu0z@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Most fixed in V22, some please see inline comment Thanks. On 2021/9/9 18:33, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > > 07/09/2021 14:56, Chengwen Feng: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -496,6 +496,10 @@ F: drivers/raw/skeleton/ >> F: app/test/test_rawdev.c >> F: doc/guides/prog_guide/rawdev.rst >> >> +DMA device API - EXPERIMENTAL >> +M: Chengwen Feng >> +F: lib/dmadev/ [snip] >> + >> +/* Enumerates DMA device capabilities. */ > > You should group them with a doxygen group syntax. > See https://patches.dpdk.org/project/dpdk/patch/20210830104232.598703-1-thomas@monjalon.net/ Because RTE_DMADEV_CAPA_* has multiple lines of comments, the effect is not good when using group syntax. Also consider using enum to define, but its value is uint64_t, and enumeration is generally of the int type. So it stays the same here. > >> +#define RTE_DMADEV_CAPA_MEM_TO_MEM (1ull << 0) > > Please use RTE_BIT macro (32 or 64). > >> +/**< DMA device support memory-to-memory transfer. >> + * >> + * @see struct rte_dmadev_info::dev_capa >> + */ > [snip] > > This series add one file per patch. > Instead it would be better to have groups of features per patch, > meaning the implementation and the driver interface should be > in the same patch. > You can split like this: > 1/ device allocation > 2/ configuration and start/stop > 3/ dataplane functions > > I would suggest 2 more patches: > 4/ event notification > see https://patches.dpdk.org/project/dpdk/patch/20210730135533.417611-3-thomas@monjalon.net/ > 5/ multi-process > see https://patches.dpdk.org/project/dpdk/patch/20210730135533.417611-5-thomas@monjalon.net/ > The multi-process have many modify for device allocation, because the coupling between the two is deep, I combines them to one patch. > > Thanks for the work > > > . >