Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

[Anoob Joseph <anoob.joseph@caviumnetworks.com>]

Hi Akhil, Radu,

Could you review the patch and share your thoughts on the proposed change?

Thanks
Anoob

On 01/22/2018 06:41 PM, Anoob Joseph wrote:
> This series adds support for setting & retrieving per packet protocol specific
> metadata. This is primarily required by the application to monitor sequence
> number overflows in inline protocol processing.
>
> The feature is added to the existing set_pkt_metadata API. The existing API
> passes all arguments directly. This series introduces a new structure which
> could be used to pass all metadata required in such cases.
>
> The patch set adds the ability to both set & retrieve such parameters. The idea
> is to make the application determine the sequence number to be used, where it
> is supported. If the PMD doesn't support it that way (as in the parameters are
> maintained by PMD/device), then application could just retrieve the value and
> see if there is any overflow etc happening.
>
> SA expiry/overflow monitoring requires knowing the latest sequence number
> on an SA. So this change allows that ability - for now for the outbound SA.
>
> Anoob Joseph (3):
>    lib/security: set/retrieve per packet protocol metadata
>    net/ixgbe: use structure for passing metadata
>    examples/ipsec-secgw: support for setting seq no
>
>   drivers/net/ixgbe/ixgbe_ipsec.c           |  5 ++-
>   examples/ipsec-secgw/esp.h                |  9 +++++
>   examples/ipsec-secgw/ipsec.c              | 42 +++++++++++++++++---
>   lib/librte_security/rte_security.c        |  7 ++--
>   lib/librte_security/rte_security.h        | 66 ++++++++++++++++++++++++++++---
>   lib/librte_security/rte_security_driver.h |  3 +-
>   6 files changed, 112 insertions(+), 20 deletions(-)
>