From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EBFEA0545; Thu, 23 Jun 2022 02:30:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0D0F4069C; Thu, 23 Jun 2022 02:30:20 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id C53A9400D6 for ; Thu, 23 Jun 2022 02:30:19 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LT1M72qwWzkWRx; Thu, 23 Jun 2022 08:28:35 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 23 Jun 2022 08:30:17 +0800 Subject: Re: [PATCH 1/2] rawdev, dmadev: remove passive voice in function doc To: Stephen Hemminger , CC: Bruce Richardson , Kevin Laatz References: <20220622202738.401690-1-stephen@networkplumber.org> <20220622202738.401690-2-stephen@networkplumber.org> From: fengchengwen Message-ID: <4aecd0c3-42f7-f0c4-c2bb-70678c0925b1@huawei.com> Date: Thu, 23 Jun 2022 08:30:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20220622202738.401690-2-stephen@networkplumber.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2022/6/23 4:27, Stephen Hemminger wrote: > Remove extraneous phrase "This API is used to" and use > active instead of passive voice when describing a function. > > Signed-off-by: Stephen Hemminger > --- > drivers/raw/ioat/rte_ioat_rawdev.h | 2 +- > lib/dmadev/rte_dmadev.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h > index 6cc1560a6402..0e79f754723d 100644 > --- a/drivers/raw/ioat/rte_ioat_rawdev.h > +++ b/drivers/raw/ioat/rte_ioat_rawdev.h > @@ -123,7 +123,7 @@ rte_ioat_fence(int dev_id); > /** > * Trigger hardware to begin performing enqueued operations > * > - * This API is used to write the "doorbell" to the hardware to trigger it > + * Writes the "doorbell" to the hardware to trigger it > * to begin the operations previously enqueued by rte_ioat_enqueue_copy() > * > * @param dev_id > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h > index a7081e633c2a..e7f992b734fc 100644 > --- a/lib/dmadev/rte_dmadev.h > +++ b/lib/dmadev/rte_dmadev.h > @@ -970,7 +970,7 @@ rte_dma_fill(int16_t dev_id, uint16_t vchan, uint64_t pattern, > * > * Trigger hardware to begin performing enqueued operations. > * > - * This API is used to write the "doorbell" to the hardware to trigger it > + * Writes the "doorbell" to the hardware to trigger it > * to begin the operations previously enqueued by rte_dma_copy/fill(). > * > * @param dev_id >