From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 189F8A0C43; Wed, 20 Oct 2021 13:55:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01FFC4118F; Wed, 20 Oct 2021 13:55:57 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 83DBA40142 for ; Wed, 20 Oct 2021 13:55:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id F3EBF5C004E; Wed, 20 Oct 2021 07:55:54 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Wed, 20 Oct 2021 07:55:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=1/TqjC/ZrtVoCHYwVVumUXivXe545g1 /0PisNU0hiW4=; b=Gy/UbY9eRVsF9+k+nfRHQubS7NwassE1ike3XDf0xYMvLe/ zFrPHueKP2dztgWIhN6zf0fa+126JjKEEiAsWj+zMSuTQaVR9SFxNDXPGF2OV4NU hyVKZmXY+qzHEKwIoYb6iKRGAz2j0v2CNUay+BYZjNcyk1qwm5olwfIY62XMdMcT pPSkRekJxYITZa1M1FSiSJZX08u0UIA4Fzhxkqsu9QugQCPFl+q1yZyJdS3Cq2gd 96bb7FvbxOFUZcWDycNSJUSvV/05mMDdJYT1fnAl/pfgxhvUpzwjwiDWU6RU6b1F E49faSdwSBHVkdzOJzJOgxvWGZP/7YmTASnsz1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1/TqjC /ZrtVoCHYwVVumUXivXe545g1/0PisNU0hiW4=; b=STlyi83dlbECT0uVVjyFrh B6ZWr8A71HJTHMvXMnTg4lBC2Q+5fQgujKYSoDNk9ck2ivrQQDbs0XDULPpLLnEZ 5PbqvfN25RQ673r2sssAqTpZQ0hxlAGQHgffs831J5OsKhf3cwL18I6lU0z/VtmQ axsFaSLBCIF+E2NdV6qc/PRpXrNLv9A2d+Lja3ZbXXuJDx1EVYc6zZz/P1+aSnlz XJmEunNNILexUFAlOqlpWsC6DJwSYDwM3IcPmMLMF3z4T07HlQZl9RmxPjca+amu TfyurirsRezj3E44g4cMpzXRXyvmh+j+kNXhejqxPbmnqwxF90BCun0FNKoEMSHQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvgedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepifgrtoht rghnpgftihhvvghtuceoghhrihhvvgesuhdvheeirdhnvghtqeenucggtffrrghtthgvrh hnpefguefhffelleduueehueetueefgedtieevudduhfegveetuedtleeuffeuheekfeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhhivh gvsehuvdehiedrnhgvth X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9F87021E006E; Wed, 20 Oct 2021 07:55:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1369-gd055fb5e7c-fm-20211018.002-gd055fb5e Mime-Version: 1.0 Message-Id: <4aefeffc-35a9-4f1f-acc3-4d4682587b81@www.fastmail.com> In-Reply-To: <20211020111230.2441949-4-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211020111230.2441949-1-xuemingl@nvidia.com> <20211020111230.2441949-4-xuemingl@nvidia.com> Date: Wed, 20 Oct 2021 13:55:18 +0200 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Xueming(Steven) Li" , dev@dpdk.org, "David Marchand" Cc: "Thomas Monjalon" , "Lior Margalit" Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v4 3/3] test/devargs: add devargs test cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 20, 2021, at 13:12, Xueming Li wrote: > Initial version to test global devargs syntax. > > Signed-off-by: Xueming Li > --- > app/test/meson.build | 5 ++ > app/test/test_devargs.c | 184 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 189 insertions(+) > create mode 100644 app/test/test_devargs.c > > diff --git a/app/test/meson.build b/app/test/meson.build > index a16374b7a10..c4b0241010d 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -399,6 +399,11 @@ if dpdk_conf.has('RTE_NET_RING') > fast_tests += [['latencystats_autotest', true]] > fast_tests += [['pdump_autotest', true]] > endif > +if dpdk_conf.has('RTE_NET_VIRTIO') > + test_deps += 'net_virtio' > + test_sources += 'test_devargs.c' > + fast_tests += [['devargs_autotest', true]] > +endif Hi Steven, Thanks for adding new use-cases and expanding the expect. The dep check for the test can be improved I think. When the build is shared, not all built drivers will be available, even if part of the meson config. It might generate false negative when running your test. Additionally, even if net_virtio is not built, a subset of your test remains valid. Finally, net_virtio might not be generic enough as a driver. A simpler one could be used, such as net_ring maybe. Instead of checking the dependencies in the meson file, you could detect support in preamble of the test: bool pci_bus_avail = (rte_bus_find_by_name("pci") != NULL); bool vdev_bus_avail = (rte_bus_find_by_name("vdev") != NULL); bool eth_class_avail = [...] Then during the test case, depending on the expect part of list[i], you can skip the case if its deps were not found. In that case, am INFO or DEBUG level message could be printed to say that the test was skipped. -- Gaetan Rivet