From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FA25A0521; Tue, 3 Nov 2020 14:11:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45DCBCA39; Tue, 3 Nov 2020 14:11:09 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A4CF1CA36 for ; Tue, 3 Nov 2020 14:11:07 +0100 (CET) IronPort-SDR: bvUIRCYeIeuqMWK6a+WZMYEzHknPjzmOMM0CNHzPJrIBW3ZgB40DbTSkYh3HRuL09lVwEzN0Re spb2jPOi7gcA== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156037158" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="156037158" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 05:11:05 -0800 IronPort-SDR: 33rBut+XOufflbZmTm/MYY05pA6E220g1SqwQcWLpbwQk4uNv3CRhv8BN0rNhpEXfaFzOcWLqD 6lP7kSswrlCA== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538486487" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 05:11:04 -0800 To: Andrew Boyer , dev@dpdk.org Cc: cardigliano@ntop.org References: <20201102183527.69209-1-aboyer@pensando.io> From: Ferruh Yigit Message-ID: <4b0ab4ff-4bf8-a4a5-67fe-11ad8d7d45c3@intel.com> Date: Tue, 3 Nov 2020 13:11:02 +0000 MIME-Version: 1.0 In-Reply-To: <20201102183527.69209-1-aboyer@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 6:35 PM, Andrew Boyer wrote: > These patches make some minor changes to the ionic PMD. This is my first > patch submission to DPDK, so please let me know if there is anything amiss. > > Andrew Boyer (8): > ionic: update documentation and MAINTAINERS > ionic: connect to the meson build system > ionic: update ionic_if.h to the latest version > ionic: check for devcmd/admincmd completion more frequently > ionic: remove some unused fields > ionic: convert 'deferred' boolean to a flag bit > ionic: warn if RTE tries to enable loopback mode > ionic: nits - whitespace, logging, helper variables > Hi Andrew, Can you please use "net/ionic: " prefix for the patch titles. Also please fix warnings of the following scripts: ./devtools/checkpatches.sh -n8 ./devtools/check-git-log.sh -n8 checkpatch reports following typos, you need codespell to see them, I am pasting here for any case: ### ionic: update ionic_if.h to the latest version WARNING:TYPO_SPELLING: 'Maximim' may be misspelled - perhaps 'Maximum'? #355: FILE: drivers/net/ionic/ionic_if.h:404: + * @max_frame_size: Maximim size of frames to be sent WARNING:TYPO_SPELLING: 'tranceiver' may be misspelled - perhaps 'transceiver'? #1158: FILE: drivers/net/ionic/ionic_if.h:1236: + * @xcvr: tranceiver status WARNING:TYPO_SPELLING: 'autonegotation' may be misspelled - perhaps 'autonegotiation'? #1219: FILE: drivers/net/ionic/ionic_if.h:1328: + * @IONIC_PORT_ATTR_AUTONEG: Port autonegotation attribute