From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE38C454EF; Tue, 25 Jun 2024 13:17:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D52CC42D7B; Tue, 25 Jun 2024 13:15:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id E890C42759 for ; Tue, 25 Jun 2024 13:15:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314123; x=1750850123; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1XwNm/oix+BScuR4SNuNWHi9DB5VHiYCyczJ0yu7OI4=; b=mcTtQnPgKSMADqyRqvyH8YszjX0BtKTjkRExgBO6aIjLazSwC4ttZa3P Xrx0T7SbeH6W/WsPzQiociT2iettV1qMIlV0UnGo01ERQsD2bwSypnFB6 klAjngvhTvisXc5eLe8MmAu+5MI/8AuGrpyPue4VzuPptSlSKonmNcZOh gNIpAl6qx2iBQAeQvmOpQ38OFujP4CltdnWqoFZT0Jh+sdZYYORA+0GWr xCxx4BMU8I8wHGVnfx3MmEN49Q1HmHD6nStoeSPmCCwjyF261Zi3RBeax FkgQHdUIsq5uBRYERfx7czKG95ZPJUQ18xAffKR+M+0LRBZ3RVnaVyLv5 A==; X-CSE-ConnectionGUID: gDSvDaJbT8aX+3U8xtlKpQ== X-CSE-MsgGUID: fVibn+HPQ1K1it1RN1jMmw== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080093" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080093" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:15:22 -0700 X-CSE-ConnectionGUID: tonzhS8nSX2ZkKmZCho+iw== X-CSE-MsgGUID: yNknWbzkQlq22p7b4KxmuA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43718962" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:15:22 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Jesse Brandeburg , bruce.richardson@intel.com, ian.stokes@intel.com Subject: [PATCH v3 014/129] net/ice/base: refactor (non) bitmap declarations Date: Tue, 25 Jun 2024 12:12:19 +0100 Message-ID: <4b220df4664f3730c847c184a6fddcf870932d44.1719313663.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jesse Brandeburg The firmware interface definition file mistakenly started using bitmap declarations for its storage in a couple of structures. The data structure contains a "bit-map" of bits that the hardware/firmware sets or reads but it's not a DECLARE_BITMAP style bitmap and it's not accessed with the set_bit/clear_bit operators, so stop declaring them that way. Signed-off-by: Jesse Brandeburg Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h index 56c9a4813e..3decaee546 100644 --- a/drivers/net/ice/base/ice_adminq_cmd.h +++ b/drivers/net/ice/base/ice_adminq_cmd.h @@ -796,7 +796,7 @@ struct ice_aqc_recipe_data_elem { struct ice_aqc_recipe_to_profile { __le16 profile_id; u8 rsvd[6]; - ice_declare_bitmap(recipe_assoc, ICE_MAX_NUM_RECIPES); + u8 recipe_assoc[DIVIDE_AND_ROUND_UP(ICE_MAX_NUM_RECIPES, BITS_PER_BYTE)]; }; /* Add/Update/Remove/Get switch rules (indirect 0x02A0, 0x02A1, 0x02A2, 0x02A3) @@ -972,7 +972,7 @@ struct ice_sw_rule_vsi_list { /* Query VSI list command/response entry */ struct ice_sw_rule_vsi_list_query { __le16 index; - ice_declare_bitmap(vsi_list, ICE_MAX_VSI); + u8 vsi_list[DIVIDE_AND_ROUND_UP(ICE_MAX_VSI, BITS_PER_BYTE)]; }; #pragma pack() -- 2.43.0