Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Dariusz Sosnowski]

Hi,

On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote:
> > Substituting options with NOOP might cause rte_ipv4_fragment_packet to produce more fragments than necessary, since options with copied flag unset will still occupy space in IPv4 header.
> --The "ip_options_fragment" just make a replacement and doesn't change the length of the IPv4 header.So I don't quite understand why it leads to produce more fragments.
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.

Best regards,
Dariusz Sosnowski



 

Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Huichao Cai]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
--Do I need to modify it this way?

[-- Attachment #2: Type: text/html, Size: 470 bytes --]

RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Ananyev, Konstantin]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

I didn't look at it in detail yet,
just wonder would be real gain in terms of space?

From: Huichao Cai <chcchc88@163.com>
Sent: Thursday, December 2, 2021 11:39 AM
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org
Subject: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
--Do I need to modify it this way?




[-- Attachment #2: Type: text/html, Size: 4278 bytes --]

Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Huichao Cai]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

Perhaps performance is more important.This code comes from the linux kernel(5.10.9 and so on). :)
It is more performance-focused based on comments. :)




[-- Attachment #2: Type: text/html, Size: 715 bytes --]

Re:Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Huichao Cai]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]







Hi everyone,


This patch hasn't changed status for a long time, I want to know what the current situation of this patch is?


Huichao Cai





















 

[-- Attachment #2: Type: text/html, Size: 2313 bytes --]