From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 759BFA0C41; Thu, 30 Sep 2021 15:00:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59C9C41109; Thu, 30 Sep 2021 15:00:52 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5CE5541103; Thu, 30 Sep 2021 15:00:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="286197738" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="286197738" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 06:00:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="457427942" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 30 Sep 2021 06:00:48 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 06:00:48 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 06:00:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 06:00:48 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 06:00:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I+So/FMNpZbuvFBnXj3nUolywrYfgtAGevH91sFL72Nb8puIg2h+R2fQ+VAcrYwjE8Ifa5zr0xbNiLhd/328ZXiDKVhBfjzOdU2dcp+es3sQG5BZmNyDvMCnc0zRiTVQf35qyKK1X3QT70HruRQ4DqNjSFnzx9pEXjkiKom0CrHoC+1mRSMEpSZ5sk99rJxV156V/JrHsohi867W9TeK4fXGNse4SDP/tyLI/In6kfLZrteY064Hjm4TdYr65Sg4LKI9vJgXY/dbRhBSjvSD4RNRCYOKYwgpHq97oWkvreEUi8rosUj9VzTZ9a12HDT3AwD3cVLmHSLi1LenvVys6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=akfS9nMIHXuZuo47/M+bOsNgVQ1lFF+lExo9H0W3BLY=; b=nsPGLP3diDJaAhGnZOpeg8OcEdSobAgVIEDP1OTnhoeMDCZe9MPlzu/kIrS/8OdRb1UOk0UcKF2saYsbnVbO8mBUZMlybiqqMzkYqV0mFk7HxS4o2L6GEALHONxmfE7WRcaTi2H4jF38Rre3sPTe2CT99x2SSCrPpxg/DEkniuWu9NPRK23gyizqlty6vLzO7yuChrWhHGT3uIxKuCwyD3GtWSCHPyaO9y6wAl+OHtNhQZtFCm4e4bgH38kZzQNoFkFTPP43z1YwSrNUUFqkRkCEmWR1WEsMg7oq/6i9rYLzz4m/kh2GAjaaD61Rx2tNIORo1s7WaA4dUvAwdFbQZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=akfS9nMIHXuZuo47/M+bOsNgVQ1lFF+lExo9H0W3BLY=; b=Zy4X/1sixi5Cu9hIOYOkZnq7JJhhjv1lm9WAsksQRkP472LVFKVshNWmc8HGdPSBPt6QGuNt+L5Tv9CeXnLVpA6sCMECVBBYYC9ly5cegy4aRLKoKc9vlHfY4+T/RTPTy/pfgWn5cFfjv9JkDJQUfn79/gNc3KJOf12ga7xOc9s= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 30 Sep 2021 13:00:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 13:00:44 +0000 To: Andrew Rybchenko , Stephen Hemminger CC: Rasesh Mody , Shahed Shaikh , Hemant Agrawal , Sachin Saxena , Haiyue Wang , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Harman Kalra , Xiao Wang , Thomas Monjalon , , References: <20210928141627.904787-1-andrew.rybchenko@oktetlabs.ru> <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru> <20210928101054.0f6ad088@hermes.local> <20f9d684-4a15-b870-672f-7301bd0503a0@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com> Date: Thu, 30 Sep 2021 14:00:33 +0100 In-Reply-To: <20f9d684-4a15-b870-672f-7301bd0503a0@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Thu, 30 Sep 2021 13:00:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8277187a-f86f-4024-0d55-08d984124ff1 X-MS-TrafficTypeDiagnostic: PH0PR11MB4981: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1pEvt5NBXJkAVl8GEcHLzkloklMEPdbuwr/WL/WNB741qRUj6CToaKALS4LVapP8twr+jnKqUfbbUf0juSt63/+N4oEuJJ0Ku4aLOGrMDRcXPz+M8zHvNYHwET+VMbJwU1eS0tbET/a5rCmML9vXX7BMjP4uNgPgUgkOsjgARyG9MJrGmYhKFzvHQbRDUIA3Ku7RenKLkSE4hWY5nxcRpmt4POkGVbdLVeQ4SHACCfGJPdnA+uF8xXbeF9MvQ9krdCbRWFZYTz3kAUR0Dyh/Sq9+Sx8vPhuGchQ0PKWg/07Z1ofPjDqEggXtPt0h4jtXye4xnx2QLLZ6BDh6JJ1Zxl+CwxiZXTeWDWRrFdPQt2bTq/pIzowBz4AMcb2jRQBK4T0jvv6ErV65SLudNHZHRVfn9usV+AHYOhzeyGc/TeC7OqVRTn3hBKuEbx++EKEIarHL9+8MmSg0zxtgWr4NwPuKY38BMF7yllK7AadrcKvh5B7tKMh75OrSCoUgNV1/D943yy9F3eKFfCdrUmuzYO1BfbVFZqccya2d4fbRDv2FUfSEGKO6W8Cn+rxuVeNBdAJqxUnIP5BHQqb/WZgOaxb5yg4hUiphVNj2o5vTJrcTVWZuEgyBX/Wxt5WdbKHl7WxZx8j5qVwp1O/xZf/ZccVSTw0lY0PouWuK4R0FognDwF6H79ejYoeNd103D1FKj0bUPfLUZsDEfihrX5zkTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(38100700002)(6486002)(8936002)(7416002)(31696002)(186003)(86362001)(53546011)(26005)(83380400001)(44832011)(4326008)(5660300002)(16576012)(508600001)(110136005)(54906003)(316002)(956004)(66556008)(2616005)(66476007)(8676002)(66946007)(2906002)(36756003)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUxmNmNMUi9HL2RnZWZxQjE0VCtrWXg3OVBvcUVzT2NucS90ZVJuTXRoUDM5?= =?utf-8?B?L1kxdFEwVW9Qcmc3TlJVUzVkcnZ1d1RocWg5ajlqTGlLdzFtb2p0N2U2Rnpu?= =?utf-8?B?cWRoN3ZQOFh1THdnSlJwaVJLYnc0NURPbHdlakxLYWkrTVlyNjNYU2tnclhy?= =?utf-8?B?aDFaaVBPSkRWNUVpVlNCejhHU3h5d01tOUNwbnlQdUZpa3FQbENIKzBQcHZl?= =?utf-8?B?OFhCZVc2ZG9Fd2JVekFpTzN3ZTVXZkpRdDUvNWxpVGdGQ0R0YVVBY2RQa1JC?= =?utf-8?B?Y3lrcEx0OW5Gek4rVHVuTExDZi95akhLamRFeFA0b1hFZFhCd2p5L0tuVjdZ?= =?utf-8?B?OXp5UFZ5WDVzdkxVSkV4dWlRb20rdTZYUk1VMFlDeTkzRVBZZWd3YVFqY3BZ?= =?utf-8?B?UGt0NlRTc3h1dlJwTHlJUm5YWnNobDFCaFBBUzBjaUk3MTczcmJqcDhCN1dt?= =?utf-8?B?Uy9iblNxM09xdXJETWg4d210WDhiL05uV1VzanNITHdVbHBXaFBXdWVaWUty?= =?utf-8?B?SlRBZUJWYUcyUGJ3ZTJJSlJudVRac0FFRkJxb1VsMUNkVmgvZjhxc2hLdERT?= =?utf-8?B?NFhHbjVrSm1kYnRLeWhwNWtGc3dtaGtXSUdXRVl2TzBwY0IrSEY0YmYwbnA5?= =?utf-8?B?a242cmhFamRCK21nclUreVZVKzNFVVJOa3NxMytrN0IzNkxYWVk4VkFwNWox?= =?utf-8?B?VWRqbEp6YW1vWm1DWm8zY25zMnVqWmQxeFVkTUdjRDlCcWZGQVQrQ2xHbDdW?= =?utf-8?B?cmlWWHFaSTc0NklWaGpiOVQ0UE5JbmlSaU00NlNjODRvS1RPaXM0cmZobWRi?= =?utf-8?B?SStXUDNSajM1a21HR1NhZ3VkNjZFcTFRMDBuZVZpY0trUnd2WHhsTlcvUDRa?= =?utf-8?B?QUd4QytIRFB3ODRnaEF4ekxaUWkwWVQ2Mk5YOWJFdUdGVHNRcHVMU0todWIv?= =?utf-8?B?L0ZsUjUyTFJUbWRqWi8rVXdaRmJPZGRhU3ZyY01WaHRNNGNIYzJ5QUxvYjVy?= =?utf-8?B?QVRtNFFpZ3ZyOG9tWHZnS2xjanNONTluVXowNFRNRjFYU1Y0ZU1QTU4veFZZ?= =?utf-8?B?cDBYdS9aQ29YZEplcDU5NWZxOTRLZk5uOUhWK040bHJSYUhHTFhHQmV4NjV3?= =?utf-8?B?eHB3N3pWWit6YXdqLzBjRnZUMnByc2x5SjlweTlzK2ppWUNQWUtCMi9Xblh5?= =?utf-8?B?OTNWQlNGWjJGdGNzSjI2NTZOYWIxenMrL0c3L2xBSFRtZG56NXIyRlVpeDJl?= =?utf-8?B?TGxJQ2tqT3FPNlBNc0NyZldkK2VuTlV2aDJpQUllMnp0ZGgxNHZPTm4vWUJy?= =?utf-8?B?UUFtR0l4TU93SW5HWTJGU3g0OCtwb3NTek9lYldkbzBoUHJUREZXZFZzck5J?= =?utf-8?B?cG5hazNIRjNnVUwrVDc0UzJDbjFwOVR1eGgzWkVNZXE4aW5ldm4xTTV0a2p3?= =?utf-8?B?TnJGNkgxM0t1Z3BRV0Nyb2xjZHpZZW53OFVkY3lISDVZTWg3R2phb0NxRnR3?= =?utf-8?B?OUQrTk5wR3VhL2lFbzF3OURNNk1wM1NMb0IyUFFQZTZIU0FUY1QxMldTUGJF?= =?utf-8?B?QmF2L0lzenlhSlNpSXhDSEFlbnZUZDgxSEpSWHY1LzQ4RlhMd3RZN3A1K09V?= =?utf-8?B?TERUYWI4dlcxZTdrRDJLc0NGam4xam5uY1R5S3NTRlRZS0ovbEZoNFlGWld5?= =?utf-8?B?UktZQU5pQTdoMzZ2N0wvcnVzalUzOGYzUCtoaFIvTTFRNHF5R2w0WEltMEN2?= =?utf-8?Q?HBd77uFNJGrJbUWpbYZXPKabtENiEEA2yAFYVOI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8277187a-f86f-4024-0d55-08d984124ff1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 13:00:43.9492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rlpv7p109vKHfbdHK1jm2TFwGWHzcgayH/YQ/m2tW1A5tW7y3v1fxlp60zq9fIY60LO1yf7mRKo7o/msewE4Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2021 7:38 AM, Andrew Rybchenko wrote: > On 9/28/21 8:10 PM, Stephen Hemminger wrote: >> On Tue, 28 Sep 2021 19:48:54 +0300 >> Andrew Rybchenko wrote: >> >>> Some drivers do not provide per-queue statistics. So, there is no point >>> to have these misleading zeros in xstats. >>> >>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Andrew Rybchenko >> Really? >> It is useful to have zeros rather than random data there. > > I guess there is a misunderstanding here. Auto-filling xstats is > an addition of per-queue basic statistics to xstats by ethdev > layer. It makes sense to do it if and only if there is some > sensible data there. > > There is a related deprecation notice saying that per-queue > stats should be removed from basic stats since per-queue > stats should be provided by xstats API natively. > > Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means > that corresponding driver is not ready vs the deprecation notice. > So, I want to clean it up to see not yet ready drivers only. > As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means, driver is not ready on representing queue stats in xstats and ethdev layer is filling it automatically from basic stats. First we should wait for drivers to implement it, later clean queue stats from basic stats and remove the flag. I am not sure if we can remove the deprecation notice in this release, but agree to add a deadline for the drivers, which can be 22.11.